Skip to content
This repository has been archived by the owner on Aug 24, 2023. It is now read-only.

fix(meta): refine std features and meta-ethereum-chain-id #143

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

canonbrother
Copy link
Contributor

@canonbrother canonbrother commented Oct 31, 2022

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Mild fixes for std
Its cherry pick from #123, to avoid dangling commit
8beafff
e9a8e19

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for metachain ready!

Name Link
🔨 Latest commit 74b1d19
🔍 Latest deploy log https://app.netlify.com/sites/metachain/deploys/635f643a376e87000949a977
😎 Deploy Preview https://deploy-preview-143--metachain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@canonbrother canonbrother temporarily deployed to Release Docker October 31, 2022 05:59 Inactive
@github-actions
Copy link

Docker image for defich/metachain is ready!

Built with commit ec6e300

  • docker pull ghcr.io/defich/metachain:ec6e3005e2575ec47bc651d6012d805ae34923b1
  • docker pull ghcr.io/defich/metachain:pr-143

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 6.31% // Head: 3.85% // Decreases project coverage by -2.46% ⚠️

Coverage data is based on head (74b1d19) compared to base (56c3771).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #143      +/-   ##
========================================
- Coverage   6.31%   3.85%   -2.47%     
========================================
  Files         15      11       -4     
  Lines       1788    1736      -52     
  Branches       4       0       -4     
========================================
- Hits         113      67      -46     
+ Misses      1675    1669       -6     
Impacted Files Coverage Δ
packages/network/src/NetworkConfig.ts
packages/testcontainers/src/MetaChainContainer.ts
packages/testcontainers/src/index.ts
ts-tests/src/utils/constant.ts

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@canonbrother canonbrother marked this pull request as ready for review October 31, 2022 07:24
@fuxingloh fuxingloh merged commit 69684c9 into main Oct 31, 2022
@fuxingloh fuxingloh deleted the canonbrother/rm-default-features-node-cargo branch October 31, 2022 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants