Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getblock older hex behaviour #2296

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Fix getblock older hex behaviour #2296

merged 1 commit into from
Aug 7, 2023

Conversation

prasannavl
Copy link
Member

Summary

  • getblock RPC #2291 broke older behaviour of include_hex by properly carrying that across the call tree.
  • However this breaks many tests and compatibility. This restores the older behaviour unless version > 2.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit e6da5f3 into master Aug 7, 2023
@prasannavl prasannavl deleted the pvl/fix-getblock branch August 7, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant