Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numeric prefix to all network upgrades #2292

Closed
wants to merge 5 commits into from
Closed

Numeric prefix to all network upgrades #2292

wants to merge 5 commits into from

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Aug 6, 2023 •
edited
Loading

Summary

  • Adds a numeric prefix to all network upgrades: DF<num><name>
  • This is important for code maintainability and readability. Provides better context on which fork comes after which more intuitively.
  • Note: The first commit is pure automated refactor. Any other amendments to go after.
  • Possible TODO: Add -df<num> flag aliases to make it easier.

Note: Might be better to wait for #1633 / #2068 iterations to be finished first before merging this.

Based on: #2291
Blocked by: #2068

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@Bushstar Bushstar closed this Oct 6, 2023
@Bushstar Bushstar mentioned this pull request Oct 6, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sieniven sieniven sieniven approved these changes

@Jouzo Jouzo Jouzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prasannavl @Jouzo @sieniven @Bushstar