Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve choices in rake setup #61

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pjungwir
Copy link

This PR bundles three minor improvements, all around Postgres connection parameters:

  • You can give a postgres port, in case you have multiple versions of postgres installed.
  • We urlencode the password in your connection URL, in case it has special characters.
  • We print the correct default database name (postgres_ext_serializers_test vs postgres_ext_test).

Btw I'd be happy to take over maintainership of this gem if you have abandoned it. (I realize I probably need to renovate postgres_ext too or switch this gem to ctes_in_my_pg.) I've taken the approach of generating JSON in Postgres on a bunch of projects, but with manual SQL, and having this gem would be a huge improvement. Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant