Fix incorrect BNLS_SERVERLOGONCHALLENGE/PROOF responses (#8)

* Demote disclaimer to header level 2 * Fix incorrect BNLS_SERVERLOGONCHALLENGE response * Fix incorrect BNLS_SERVERLOGONPROOF response
Davnit · Mar 7, 2019 · b05aba1 · b05aba1
1 parent b2e0ba0
commit b05aba1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/BNLSProtocol/BNLSParse.java b/BNLSProtocol/BNLSParse.java
@@ -954,7 +954,7 @@ private OutPacketBuffer onServerLogonChallenge(InPacketBuffer in){
     for (int Y = 0; Y < SRP.BIGINT_SIZE; Y++)
       reply.addByte(salt[Y]);
 	for (int Y = 0; Y < SRP.BIGINT_SIZE; Y++)
-	  reply.addDWord(B[Y]);
+	  reply.addByte(B[Y]);
     return reply;
   }
   private OutPacketBuffer onServerLogonProof(InPacketBuffer in){
@@ -992,7 +992,6 @@ private OutPacketBuffer onServerLogonProof(InPacketBuffer in){
 	byte[] M2 = reservedSRPs[slot].getM2(reservedSRPs[slot].get_A(), reservedSRPs[slot].get_B());
 	OutPacketBuffer reply = new OutPacketBuffer(BNLS_SERVERLOGONPROOF);
 	reply.addDWord(slot);
-	if (equal(M1, M2))
 	reply.addDWord((equal(M1, M2) ? 0x01 : 0x00));
 	for(int Y = 0; Y < 5; Y++)
 	  reply.addDWord(M1[Y]);
@@ -1112,4 +1111,4 @@ private OutPacketBuffer onUnknown(InPacketBuffer in){
 	return null;
   }
 
-}// end of BNLS Parse class
+}// end of BNLS Parse class
diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 # JBLS
 Java Battle.net Logon Server- Java implementation of ValhallaLegend's BNLS protocol for interacting with Battle.net classic servers.
 
-# Disclaimer
+## Disclaimer
 You hereby acknowledge that JBLS is offered as-is and without warranty,
 expressed or implied. JBLS is not sponsored by Blizzard Entertainment or its
 subsidiaries in absolutely any way. Battle.net&trade; is a registered trademark