Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update various version #19

Merged
merged 1 commit into from
Jan 11, 2023
Merged

chore(deps): update various version #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .mill-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0.10.8
10 changes: 5 additions & 5 deletions build.sc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
import $ivy.`de.tototec::de.tobiasroeser.mill.integrationtest::0.6.0`
import $ivy.`de.tototec::de.tobiasroeser.mill.integrationtest::0.6.1`
import de.tobiasroeser.mill.integrationtest._
import $ivy.`de.tototec::de.tobiasroeser.mill.vcs.version::0.1.4`
import $ivy.`de.tototec::de.tobiasroeser.mill.vcs.version::0.3.0`
import de.tobiasroeser.mill.vcs.version.VcsVersion
import mill._
import mill.scalalib._
import mill.scalalib.api.Util.scalaNativeBinaryVersion
import publish._

val millVersions = Seq("0.10.5", "0.9.12")
val millVersions = Seq("0.10.8", "0.9.12")
def millBinaryVersion(millVersion: String) = scalaNativeBinaryVersion(millVersion)

object `mill-tpolecat` extends Cross[MillTpolecatCross](millVersions: _*)
class MillTpolecatCross(millVersion: String) extends CrossModuleBase with PublishModule {
override def crossScalaVersion = "2.13.7"
override def crossScalaVersion = "2.13.10"
override def artifactSuffix = s"_mill${millBinaryVersion(millVersion)}" + super.artifactSuffix()

def compileIvyDeps = Agg(ivy"com.lihaoyi::mill-scalalib:$millVersion")

def publishVersion: T[String] = VcsVersion.vcsState().format(tagModifier = _.dropWhile(_ == 'v'))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So stripping the v is no longer necessary as this is done by default now. However, it got me wondering. I don't see any git tags associated with this repo. Are you just manually tagging via GitHub or something or how are you releasing?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ckipp01 I've not been so involved with this repo recently but as far as I know we're just using git tags for releasing on tag pushes
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this PR. I did not quiet understand the next steps. Is publishVersion defined by default without v now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ckipp01 I've not been so involved with this repo recently but as far as I know we're just using git tags for releasing on tag pushes

Yup, this was my bad, I hadn't fetched everything upstream and was only dealing with my fork. Just ignore that part.

Sorry I missed this PR. I did not quiet understand the next steps. Is publishVersion defined by default without v now?

Well the logic we had here was stripping the v which as of 0.2.0 is done by default.

def publishVersion: T[String] = VcsVersion.vcsState().format()

def pomSettings = PomSettings(
description = "scalac options for the enlightened",
Expand Down