Skip to content

Commit

Permalink
Backend: removing the download source checker (hannibal002#3246)
Browse files Browse the repository at this point in the history 
Co-authored-by: hannibal2 <[email protected]>
  • Loading branch information
@hannibal002 @DavidArthurCole
2 people authored and DavidArthurCole committed Jan 18, 2025
1 parent 10afe90 commit e60ef86
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 161 deletions.
4 changes: 0 additions & 4 deletions src/main/java/SkyHanniInstallerFrame.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import at.hannibal2.skyhanni.tweaker.DownloadSourceChecker;

import javax.imageio.ImageIO;
import javax.swing.ImageIcon;
import javax.swing.JButton;
Expand Down Expand Up @@ -96,8 +94,6 @@ public SkyHanniInstallerFrame() {

public static void main(String[] args) {
try {
DownloadSourceChecker.init();

UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName());
SkyHanniInstallerFrame frame = new SkyHanniInstallerFrame();
frame.centerFrame(frame);
Expand Down
153 changes: 0 additions & 153 deletions src/main/java/at/hannibal2/skyhanni/tweaker/DownloadSourceChecker.java
View file
Original file line number Diff line number Diff line change
@@ -1,153 +0,0 @@
package at.hannibal2.skyhanni.tweaker;

import at.hannibal2.skyhanni.utils.OSUtils;

import javax.swing.JFrame;
import javax.swing.JOptionPane;
import javax.swing.JPanel;
import javax.swing.UIManager;
import java.awt.event.WindowEvent;
import java.io.BufferedReader;
import java.io.File;
import java.io.FileReader;
import java.net.URI;
import java.net.URL;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.regex.Matcher;
import java.util.regex.Pattern;

public class DownloadSourceChecker {

private static final String MOD_VERSION = "@MOD_VERSION@";
private static final String GITHUB_REPO = "511310721";
private static final String GITHUB_REPO_TEXT = "repo_id=" + GITHUB_REPO;
private static final String MODRINTH_URL = "/data/byNkmv5G/";

private static final String[] SECURITY_POPUP = {
"The file you are trying to run is hosted on a non-trusted domain.",
"",
"Host: %s",
"",
"Please download the file from a trusted source.",
"",
"IF YOU DO NOT KNOW WHAT YOU ARE DOING, CLOSE THIS WINDOW!",
"",
"And download from the official link below."
};

public static void init() {
if (!OSUtils.INSTANCE.isWindows()) return;
URI host = getDangerousHost();
if (host != null) {
openMenu(host);
}
}

private static void openMenu(URI host) {
try {
UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName());
} catch (Exception e) {
e.printStackTrace();
}

JFrame frame = new JFrame();
frame.setUndecorated(true);
frame.setAlwaysOnTop(true);
frame.setLocationRelativeTo(null);
frame.setVisible(true);

AtomicBoolean close = new AtomicBoolean(true);

JPanel links = new JPanel();

links.add(TweakerUtils.createButton(
"Discord",
() -> TweakerUtils.openUrl("https://discord.com/invite/skyhanni-997079228510117908")
));

links.add(TweakerUtils.createButton(
"Official Download",
() -> TweakerUtils.openUrl("https://github.com/hannibal002/SkyHanni/releases")
));

JPanel buttons = new JPanel();

buttons.add(TweakerUtils.createButton(
"Close",
() -> {
close.set(true);
frame.dispatchEvent(new WindowEvent(frame, WindowEvent.WINDOW_CLOSING));
}
));

// Compile the regex pattern for matching an empty host
Pattern pattern = Pattern.compile("https:\\/\\/.*.com\\/$|about:internet");
String readableHost = uriToSimpleString(host);
Matcher matcher = pattern.matcher(readableHost);

// Check if the host is empty (Brave is cutting everything past .com/ from the host)
String cutHostMessage = "";
if (matcher.find()) {
cutHostMessage = "\n\nYour browser MAY have interfered with the download process.\n" +
"Try downloading the file using a different browser (Microsoft Edge, Google Chrome, etc.).";
}

System.err.println("SkyHanni-" + MOD_VERSION + " detected a untrusted download source host: '" + readableHost + "'");
JOptionPane.showOptionDialog(
frame,
String.format(String.join("\n", SECURITY_POPUP), readableHost) + cutHostMessage,
"SkyHanni " + MOD_VERSION + " Security Error",
JOptionPane.DEFAULT_OPTION,
JOptionPane.ERROR_MESSAGE,
null,
new JPanel[] { links, buttons },
links
);

if (!close.get()) return;
TweakerUtils.exit();
}

private static String uriToSimpleString(URI uri) {
return uri.getScheme() + "://" + uri.getHost() + uri.getPath();
}

private static URI getDangerousHost() {
try {
URL url = DownloadSourceChecker.class.getProtectionDomain().getCodeSource().getLocation();
File file = new File(url.getFile());
if (!file.isFile()) return null;
URI host = getHost(file);
if (host == null) return null;

if (host.getHost().equals("objects.githubusercontent.com")) {
if (host.getQuery().contains(GITHUB_REPO_TEXT)) {
return null;
} else if (host.getPath().contains("/" + GITHUB_REPO + "/")) {
return null;
}
} else if (host.getHost().equals("cdn.modrinth.com") && host.getPath().startsWith(MODRINTH_URL)) {
return null;
}
return host;
} catch (Exception ignored) {
return null;
}
}

private static URI getHost(File file) throws Exception {
final File adsFile = new File(file.getAbsolutePath() + ":Zone.Identifier:$DATA");
String host = null;
try (BufferedReader reader = new BufferedReader(new FileReader(adsFile))) {
String line = reader.readLine();
while (line != null) {
if (line.startsWith("HostUrl=")) {
host = line.substring(8);
break;
}
line = reader.readLine();
}
}
return host != null ? new URI(host) : null;
}
}
4 changes: 0 additions & 4 deletions src/main/java/at/hannibal2/skyhanni/tweaker/SkyHanniTweaker.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
@SuppressWarnings("unused")
public class SkyHanniTweaker implements ITweaker {

public SkyHanniTweaker() {
DownloadSourceChecker.init();
}

@Override
@SuppressWarnings("unchecked")
public void acceptOptions(List<String> args, File gameDir, File assetsDir, String profile) {
Expand Down

0 comments on commit e60ef86

Please sign in to comment.