Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Async indicator variants (proposal only) #1114

Closed
wants to merge 9 commits into from
Closed

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Nov 9, 2023

Experiment only. Considering adding indicator variants that return Task for asynchronous operations, since it may better support some additional use cases.

Generally, I'm not sold on adding these because they do not perform as well and aren't easily upgraded to support chaining and possibly streaming + people can Task.Run() to this themselves if needed.

I'll revisit this after v3 streaming features; however, opening this for feedback.

Conclusion: this is over engineered for static methods, users can simply use standard Task.FromResult<TResult>(TResult) if they want to return it in an otherwise async method.

Copy link

github-actions bot commented Nov 9, 2023

✔️ Tests 720 / 720 - passed in 7.5s
✔️ Coverage 96.46% - passed with 95% threshold
📏 5319 / 5323 lines covered 🌿 2309 / 2585 branches covered
🔍 click here for more details

✏️ updated for commit 92443f3

@DaveSkender DaveSkender added the on hold On hold / waiting label Nov 24, 2023
@DaveSkender DaveSkender changed the title add Async indicator variants feat: Async indicator variants (proposal only) Jan 1, 2024
@DaveSkender DaveSkender deleted the async branch February 8, 2024 06:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
on hold On hold / waiting
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant