-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add markdown support #2
Conversation
8fc449e
to
1019205
Compare
@lafleurdeboum I pushed some changes to the branch, it compiles for me but I didn't test if it actually works as you'd expect. |
1019205
to
910646f
Compare
910646f
to
9c8a9ba
Compare
Errr email replies don't support markdown either :( I'm reposting these comments on the web interface.
|
It does compile - and it fails to highlight markdown content. I pushed
to see that markdown content is passed as is. Run with
to see that toml contents get highlighted, or with
to see that rust contents also get highlighted. BTW the example commit should be cherry-pickable for future users. |
I fear this is just a limitation of the highlighter crate. Thanks for adding the example, that's very useful. I don't have time to dig into this, so I am inclined to just go with #3 and if someone figures out how to use this one, we can always change it out later. |
Cherry picked your example into master 👍 I'll close this for now, feel free to re-open if you want to look into why it is broken (though I assume it first needs fixing in the highlighter crate). |
Adds markdown support from MDeiml's repo. There was also iyakitang's, but it wasn't updated in 3 years. Also, MDeiml's supports YAML/TOML metadata (through syntax injection I guess/hope) and Github Flavored Markdown, which is pretty widespread.
This is still WIP. I'll test the highlighter soon to check at least basic functionality.
Their README states a block and an inline grammar. Don't know how to use that ATM.