Add U-Smoothing for Convex Clustering #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelweylandt
added
Algorithms
michaelweylandt
force-pushed
the
mw/u_smoothing
branch
from
d062576 to
d070c83
Compare
- For fair comparison with other methods (e.g., cvxclustr and cvxbiclustr) we should only record the time spent calculating the solution path and omit time spent calculating weights or constructing dendrograms - Print both total time and fit time
- Plot dendrograms with y-axis in percent - Change y-axis to "Fraction of Regularization"
michaelweylandt
force-pushed
the
mw/u_smoothing
branch
from
d070c83 to
bddb19f
Compare
- When convex clustering, it appears that the V's (active edge IDs / cluster identities) converge more rapidly than the associated rows of U, so "smooth" the estimated U by replacing each row with the mean of all rows in that cluster at each iteration Not currently doing this for CBASS since I'm not sure how to get the joint row- and column-wise cluster info with our current independent post-processing design
michaelweylandt
force-pushed
the
mw/u_smoothing
branch
from
bddb19f to
32dcfc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jjn13 This partially addresses #63 by "smoothing" the U estimates, as we've discussed.
I haven't smoothed the
CBASSestimates yet since our current approach of doing all the post-processing separately doesn't calculate the relevant cluster info... I don't think this is a problem except for theCBASSrow- and column-path plots which @agenevera thinks we should remove anyways. Thoughts?