-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature-3939][studio] FlinkSQL Studio supports real-time update task status #3941
Conversation
Set<Integer> currentMonitorTaskIds = FlinkJobThreadPool.getInstance().getCurrentMonitorTaskIds(); | ||
if (!runningJobIds.equals(currentMonitorTaskIds)) { | ||
runningJobIds = currentMonitorTaskIds; | ||
System.out.println("New IDS:" + runningJobIds.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use slf4f??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove it.
@@ -757,7 +754,7 @@ export const SqlTask = memo((props: FlinkSqlProps & any) => { | |||
showDesc={showDesc} | |||
disabled={isLockTask} | |||
desc={l('button.offline')} | |||
icon={<CloudDownloadOutlined style={{ color: 'red' }} />} | |||
icon={<MergeCellsOutlined />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rollback
@@ -729,7 +726,7 @@ export const SqlTask = memo((props: FlinkSqlProps & any) => { | |||
<Divider type={'vertical'} style={{ height: dividerHeight }} /> | |||
<RunToolBarButton | |||
showDesc={showDesc} | |||
disabled={isLockTask || JOB_LIFE_CYCLE.PUBLISH == currentState.step} | |||
disabled={isLockTask} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rollback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: