Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-3939][studio] FlinkSQL Studio supports real-time update task status #3941

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

aiwenmo
Copy link
Contributor

@aiwenmo aiwenmo commented Nov 22, 2024

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@aiwenmo aiwenmo self-assigned this Nov 22, 2024
@aiwenmo aiwenmo added the New Feature New feature label Nov 22, 2024
@aiwenmo aiwenmo added this to the 1.2.0 milestone Nov 22, 2024
@aiwenmo aiwenmo linked an issue Nov 22, 2024 that may be closed by this pull request
3 tasks
@aiwenmo
Copy link
Contributor Author

aiwenmo commented Nov 22, 2024

image

@aiwenmo
Copy link
Contributor Author

aiwenmo commented Nov 22, 2024

image

Set<Integer> currentMonitorTaskIds = FlinkJobThreadPool.getInstance().getCurrentMonitorTaskIds();
if (!runningJobIds.equals(currentMonitorTaskIds)) {
runningJobIds = currentMonitorTaskIds;
System.out.println("New IDS:" + runningJobIds.toString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use slf4f??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove it.

@@ -757,7 +754,7 @@ export const SqlTask = memo((props: FlinkSqlProps & any) => {
showDesc={showDesc}
disabled={isLockTask}
desc={l('button.offline')}
icon={<CloudDownloadOutlined style={{ color: 'red' }} />}
icon={<MergeCellsOutlined />}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollback

@@ -729,7 +726,7 @@ export const SqlTask = memo((props: FlinkSqlProps & any) => {
<Divider type={'vertical'} style={{ height: dividerHeight }} />
<RunToolBarButton
showDesc={showDesc}
disabled={isLockTask || JOB_LIFE_CYCLE.PUBLISH == currentState.step}
disabled={isLockTask}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollback

Copy link
Contributor

@zackyoungh zackyoungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zackyoungh zackyoungh merged commit 5664f55 into DataLinkDC:dev Nov 22, 2024
17 checks passed
MactavishCui pushed a commit to MactavishCui/dinky that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature][studio] FlinkSQL Studio supports real-time update task status
3 participants