Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization][Data Studio]add getSchemas and getTables api #3735

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

zhuxt2015
Copy link
Contributor

Purpose of the pull request

fix #3733
The information of schema and table is request in two api, and single api of getSchemasAndTables takes too long to obtain the information , which will cause the page to freeze

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@Zzm0809
Copy link
Contributor

Zzm0809 commented Aug 26, 2024

只修改后端无意义。前端调用接口还是之前的,前端是否可以同时优化

@zhuxt2015
Copy link
Contributor Author

zhuxt2015 commented Aug 26, 2024

只修改后端无意义。前端调用接口还是之前的
前端不会写呀,大佬,帮忙在社区找一个前端吧

@Zzm0809
Copy link
Contributor

Zzm0809 commented Aug 26, 2024

只修改后端无意义。前端调用接口还是之前的
前端不会写呀,大佬,帮忙在社区找一个前端吧

ok,我将来协助你完成此项优化

Copy link
Contributor

@gaoyan1998 gaoyan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zzm0809 Zzm0809 merged commit 63f6318 into DataLinkDC:dev Aug 28, 2024
17 checks passed
zhuxt2015 added a commit to zhuxt2015/dinky that referenced this pull request Sep 1, 2024
@aiwenmo aiwenmo added the Optimization Optimization function label Dec 17, 2024
@aiwenmo aiwenmo added this to the 1.2.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimization Optimization function
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Optimization][Data Studio] Recommend display the oracle schema in pagination
4 participants