[Optimization][script] Optimizing the classpath in the Dinky startup … #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aiwenmo,
gaoyan1998,
zackyoungh and
Zzm0809
|
close #3076 |
closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…script #3076
close #3076
Purpose of the pull request
related issue
#3076
Optimization of the classpath in the Dinky startup script
Due to the use of relative paths in the classpath, launching Dinky can only be done from the Dinky installation directory, which can be inconvenient in some scenarios. The current classpath is:
The proposal is to optimize it by using absolute paths based on APP_HOME.
Brief change log
Verify this pull request
This pull request is already covered by existing tests, such as (please describe tests).
manual test
