-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature-1620][admin] Integrate Casdoor for SSO #2250
base: dev
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1105,7 +1105,7 @@ CREATE TABLE `dinky_sys_login_log` ( | |
`id` int NOT NULL AUTO_INCREMENT COMMENT 'key', | ||
`user_id` int NOT NULL COMMENT 'user id', | ||
`username` varchar(60) COLLATE utf8mb4_general_ci NOT NULL COMMENT 'username', | ||
`login_type` int NOT NULL COMMENT 'login type(0:LOCAL,1:LDAP)', | ||
`login_type` int NOT NULL COMMENT 'login type(0:LOCAL,1:ldap,2:Casdoor)', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this mean that SSO login is a standalone login method and not a replacement for existing local logins? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Login type Casdoor is special, I think oidc (oauth2) is better than casdoor,=.= |
||
`ip` varchar(40) COLLATE utf8mb4_general_ci NOT NULL COMMENT 'ip addr', | ||
`status` int NOT NULL COMMENT 'login status', | ||
`msg` text COLLATE utf8mb4_general_ci NOT NULL COMMENT 'status msg', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better to remove
Casdoor
? eg :The default tenant does not exist
Or use an existing
USER_NOT_BINDING_TENANT
instead