Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Optimization][script] Optimizing the classpath in the Dinky startup script #3076

Closed
3 tasks done
JiaLiangC opened this issue Jan 27, 2024 · 0 comments · Fixed by #3077
Closed
3 tasks done

[Optimization][script] Optimizing the classpath in the Dinky startup script #3076

JiaLiangC opened this issue Jan 27, 2024 · 0 comments · Fixed by #3077
Assignees
@JiaLiangC
Labels
Optimization Optimization function
Milestone
1.0.0

Comments

@JiaLiangC
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar optimization requirement.

Description

优化 dinky 启动脚本的中的classpath

由于classpath 使用了相对路径，导致启动dinky 只能进入dinky 安装目录进行启动，这在某些情况下会造成不便

CLASS_PATH=".:./lib/*:config:./extends/*:./plugins/*:./customJar/*:./plugins/flink${FLINK_VERSION}/dinky/*:./plugins/flink${FLINK_VERSION}/*:./extends/flink${FLINK_VERSION}/dinky/*:./extends/flink${FLINK_VERSION}/*"

优化为使用基于 APP_HOME 的绝对路径

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@JiaLiangC JiaLiangC added the Waiting for reply Waiting for reply label Jan 27, 2024
JiaLiangC added a commit to JiaLiangC/dinky that referenced this issue Jan 27, 2024
@JiaLiangC
[Optimization][script] Optimizing the classpath in the Dinky startup …
aa4ff99 
…script DataLinkDC#3076
@JiaLiangC JiaLiangC mentioned this issue Jan 27, 2024
Merged
@gaoyan1998 gaoyan1998 removed the Waiting for reply Waiting for reply label Jan 28, 2024
@gaoyan1998 gaoyan1998 added this to the 1.0.0 milestone Jan 28, 2024
@gaoyan1998 gaoyan1998 added the Optimization Optimization function label Jan 28, 2024
@gaoyan1998 gaoyan1998 moved this to Doing in Dinky Roadmap Jan 28, 2024
@Zzm0809 Zzm0809 moved this from Doing to Done in Dinky Roadmap Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiaLiangC JiaLiangC

Labels
Optimization Optimization function
Projects
Dinky Roadmap
Archived in project
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

[Optimization][script] Optimizing the classpath in the Dinky startup … JiaLiangC/dinky
2 participants
@JiaLiangC @gaoyan1998