Extend agent payload definitions #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpddog
reviewed
Jan 18, 2024
| from enum import Enum | ||
|
|
||
|
|
||
| class SpanKind(str, Enum): |
There was a problem hiding this comment.
Can this be defined as an Annotated Field type? Something along these lines: https://github.com/DataDog/schema/blob/main/semantic-core/generation/semantic_model/registry/properties/data_policies.py#L12-L16
This way we can leverage the Fields type to define in here all of the common properties that should apply to wherever this type is used.
| from semantic_model.registry.types.trace_chunk import TraceChunk | ||
|
|
||
|
|
||
| class TracerPayload(BaseModel): |
There was a problem hiding this comment.
This should be under /payloads, no? Is this meant to be a reusable type?
Same for trace_chunk.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the
agent_payload.jsondefinition including missing fields.Also added a way to include conditionals in the generated JSON schema through the optional
customize_json_schemamethod.