General update to slack schema validation #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck to open a slack channel directly from the link
| @@ -202,7 +202,7 @@ | |||
| "then": { | |||
| "properties": { | |||
| "contact": { | |||
| "pattern": "https:\/\/[a-zA-Z0-9_\\-]+.slack\\.com\/archives\/[a-zA-Z0-9_\\-]+" | |||
| "pattern": "https:\/\/[a-zA-Z0-9_\\-]+\\.slack\\.com\/archives\/[a-zA-Z0-9_\\-]+|slack:\/\/channel\\?team=[a-zA-Z0-9]+&id=[a-zA-Z0-9]+" | |||
There was a problem hiding this comment.
can you provide some examples? thanks.
There was a problem hiding this comment.
The original pattern, https:\/\/[a-zA-Z0-9_\\-]+.slack\\.com\/archives\/[a-zA-Z0-9_\\-]+, would match, for example, the following:
https://company-nameslack.com/archives/ABCDEFG123
The addition, https:\/\/[a-zA-Z0-9_\\-]+\\.slack\\.com\/archives\/[a-zA-Z0-9_\\-]+, would confirm the .slack.com:
https://company-name.slack.com/archives/ABCDEFG123
The slack://channel pattern was one I was utilizing before I realized that copying a link to the channel would generate the archives domain, if you would like, I can update the request with it removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated slack schema to escape first period correctly, and added a check to open a slack channel directly from the link