Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse span_id from traced_planstate #36

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

bonnefoa
Copy link
Collaborator

@bonnefoa bonnefoa commented Jul 5, 2024

During first node execution, we generate a span_id. However, we only use if for Result and ProjectSet node.

Always use span_id from traced_planstate to avoid redundant span_id generation.

Fixes #34

During first node execution, we generate a span_id. However, we only use
if for Result and ProjectSet node.

Always use span_id from traced_planstate to avoid redundant span_id
generation.

Fixes #34
@bonnefoa bonnefoa merged commit 8bf2af8 into main Jul 5, 2024
3 checks passed
@bonnefoa bonnefoa deleted the optimise_traced_planstate_spanid branch July 5, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: redundant computation of span_id in TracedPlanstate
1 participant