Replace latest_trace_id by tx_start_traceparent #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the start of a transaction has a trace_context, we want to reuse it for the whole transaction. Replace latest_trace_id by tx_start_traceparent which will only be set at the start of a new transaction and update it with both randomly generated trace_id and extracted_trace_id from SQLComments. If a statement has its own trace_context, we give it priority. This fixes the issue #13 where latest_trace_id was not updated when trace_id was provided by SQLComment, leading to creating spans with a 0 trace_id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the start of a transaction has a trace_context, we want to reuse it for the whole transaction. Replace latest_trace_id by tx_start_traceparent which will only be set at the start of a new transaction and update it with both randomly generated trace_id and extracted_trace_id from SQLComments.
If a statement has its own tracecontext, we give it priority.
This fixes the issue #13 where latest_trace_id was not updated when trace_id was provided by SQLComment, leading to creating spans with a 0 trace_id.