Fix tracing of close cursor #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing a cursor will directly call ExecutorFinish. We need to create the top span for those cases. Also, as ExecutorEnd will be called, we will try to generate spans from planstate. However, traced planstates won't be available and representing planstate spans for cursor execution doesn't fit our current model. To fix this, we disable full query instrumentation for cursors. Fixes #10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closing a cursor will directly call ExecutorFinish. We need to create the top span for those cases.
Also, as ExecutorEnd will be called, we will try to generate spans from planstate. However, traced planstates won't be available and representing planstate spans for cursor execution doesn't fit our current model. To fix this, we disable full query instrumentation for cursors.
Fixes #10