Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMLII-1815] Telemetry is no longer initialized when telemetry disabled #522

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

carlosroman
Copy link
Contributor

@carlosroman carlosroman commented May 30, 2024

Even when telemetry is disabled the JMXFetch will still register an MBean server. This causes issues when run in embedded mode where there might be a custom MBean manager. This was picked up in tests here.

@carlosroman carlosroman requested review from a team as code owners May 30, 2024 09:39
@carlosroman carlosroman force-pushed the carlosroman/AMLII-1815-embedded-mode-fix branch 3 times, most recently from a7ee7fe to 10dacbe Compare May 30, 2024 10:14
@carlosroman carlosroman force-pushed the carlosroman/AMLII-1815-embedded-mode-fix branch 5 times, most recently from 0519dc0 to c522b5c Compare May 31, 2024 15:03
@carlosroman carlosroman force-pushed the carlosroman/AMLII-1815-embedded-mode-fix branch 2 times, most recently from c5e7684 to d6cfeee Compare June 3, 2024 09:23
@carlosroman carlosroman force-pushed the carlosroman/AMLII-1815-embedded-mode-fix branch from d6cfeee to 5ffabcc Compare June 3, 2024 10:03
Copy link
Contributor

@rayz rayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@carlosroman carlosroman merged commit 5391e60 into master Jun 4, 2024
9 checks passed
@carlosroman carlosroman deleted the carlosroman/AMLII-1815-embedded-mode-fix branch June 4, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants