Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMLII-1194 - Updated CI JDKs to use the current LTS versions of the JDK #491

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

AMLII-1194 - Updated CI JDKs to use the current LTS versions of the JDK #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c01ef53
Updated CodeQL to use temurin + cleaned up build command
carlosroman Oct 25, 2023
59ce856
Updated CI to use LTS versions of the JDK
carlosroman Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,34 +17,51 @@ jobs:
docker:
- image: cimg/openjdk:8.0
<<: *lint_steps

# JDK 8 (LTS) - 31 Dec 2030 (extended support)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a good reference you have for these LTS dates, may be useful to drop in here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used https://endoflife.date/oracle-jdk to work them out.

test_openjdk8:
docker:
- image: cimg/openjdk:8.0
<<: *build_steps

# JDK 11 (LTS) - 31 Jan 2032 (extended support)
test_openjdk11:
docker:
- image: cimg/openjdk:11.0
<<: *build_steps
test_openjdk15:
docker:
- image: cimg/openjdk:15.0
<<: *build_steps

# JDK 11 (LTS) - 30 Sep 2029 (extended support)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this say jdk 17?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 👍🏽

test_openjdk17:
docker:
- image: cimg/openjdk:17.0
<<: *build_steps

# Available in Ubuntu 22.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this comment mean? Is jdk 18 what ships by default with ubuntu 22.04?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at which ones we test with + which ones are in the LTS version of Ubuntu. Mainly as trying to figure out what the test matrix should look like.

test_openjdk18:
docker:
- image: cimg/openjdk:18.0
<<: *build_steps

# Available in Ubuntu 22.04
test_openjdk19:
docker:
- image: cimg/openjdk:19.0
<<: *build_steps

# JDK 21 (LTS) - 30 Sep 2031 (extended support)
test_openjdk21:
docker:
- image: cimg/openjdk:21.0
<<: *build_steps

workflows:
version: 2
workflow:
jobs:
- lint_openjdk8
- test_openjdk8
- test_openjdk11
- test_openjdk15
- test_openjdk17
- test_openjdk18
- test_openjdk19
- test_openjdk21
8 changes: 4 additions & 4 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,16 @@ jobs:
# Prefix the list here with "+" to use these queries and those in the config file.
# queries: ./path/to/local/query, your-org/your-repo/queries@main

- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up JDK 8
uses: actions/setup-java@v2
uses: actions/setup-java@v3
with:
distribution: 'zulu'
distribution: 'temurin'
java-version: '8'
java-package: jdk

- name: Build with Maven
run: ./mvnw clean compile assembly:single
run: ./mvnw --batch-mode --no-transfer-progress clean package -DskipTests=true

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2