Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up instance telemetry bean in tests #485

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Clean up instance telemetry bean in tests #485

merged 1 commit into from
Nov 2, 2023

Conversation

rayz
Copy link
Contributor

@rayz rayz commented Oct 11, 2023 •
edited
Loading

this pr:

  1. adds a cleanup for instances and their telemetry bean
  2. renames some of the instance names in our test yaml so that they are unique

now, when you run mvn test -Dtest=TestApp | grep InstanceAlreadyExistsException , there are no exceptions

@rayz rayz changed the title Clean up instance telemetry bean in tests [draft] Clean up instance telemetry bean in tests Oct 11, 2023
@rayz rayz force-pushed the raymond.zhao/AMLII-1085-instancealreadyexists branch from 7578d2e to f6d5978 Compare October 11, 2023 21:45
@rayz rayz changed the title [draft] Clean up instance telemetry bean in tests Clean up instance telemetry bean in tests Oct 12, 2023
@rayz rayz marked this pull request as ready for review October 12, 2023 14:06
@rayz rayz requested a review from a team as a code owner October 12, 2023 14:06
@rayz rayz force-pushed the raymond.zhao/AMLII-1085-instancealreadyexists branch from f6d5978 to 513e7c0 Compare October 17, 2023 15:27
@rayz rayz force-pushed the raymond.zhao/AMLII-1085-instancealreadyexists branch from 513e7c0 to 28540a6 Compare October 24, 2023 15:38
@rayz rayz merged commit 7c2921b into master Nov 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottopell scottopell scottopell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayz @scottopell