Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tomcat process signature #19328

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

daniel-taf
Copy link
Contributor

What does this PR do?

This PR adds an additional tomcat process signature that can be used for integration auto-detection.

Motivation

The current signature was not exhaustive enough as some customers were not seeing their Tomcat processes properly be detected.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs review needed

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (e6b077a) to head (8e14241).
Report is 3 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@daniel-taf daniel-taf added this pull request to the merge queue Jan 3, 2025
Merged via the queue into master with commit 9d0b4b1 Jan 3, 2025
46 of 47 checks passed
@daniel-taf daniel-taf deleted the daniel.tafoya/update-tomcat-signature branch January 3, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants