-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow SSLContext ciphers to be customized #19312
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
* allow SSLContext ciphers to be customized * Rename 19055.added to 19312.added * Update test_tls.py * Update test_tls.py (cherry picked from commit 70f03b1)
What does this PR do?
We accept a handful of SSL Ciphers. These are:
If someone wants to connect to an endpoint that doesn't use one of the above ciphers, then we'd get an SSL error. Currently, we can't configure this. This PR aims to add the ability to include and configure what Ciphers to allow.
The default behavior:
Motivation is that for the end user, this should be the most encompassing as they would just not need to care about it out of the box. For users that want to be more strict then they can configure it to do so.
The alternative, is to keep the list from above and allow users to customize it. This will work for some users and other users that uses ciphers not on the list will have to configure it in the config.
I'm open for discussion on the default behavior. Afterwards, I can push the changes to update the config templates.