Supabase integration #19307
Supabase integration #19307
Conversation
| # (C) Datadog, Inc. 2024-present | ||
| # All rights reserved | ||
| # Licensed under a 3-clause BSD style license (see LICENSE) | ||
| from datadog_checks.base.checks.openmetrics.v2.metrics import DEFAULT_GO_METRICS |
There was a problem hiding this comment.
The only thing I'd say we should do differently here is to change this metric:
We should make it an elapsed time metric. I can do that. But then we'd have to make a release and bump the min base package in this check. The easier way maybe to overwrite the metric in your metric list.
There was a problem hiding this comment.
I made the overwrite and the PR to fix it in the base class. I'm also adding some missing metrics to both.
There was a problem hiding this comment.
| # HELP postgres_exporter_config_last_reload_success_timestamp_seconds Timestamp of the last successful configuration reload. | ||
| # TYPE postgres_exporter_config_last_reload_success_timestamp_seconds gauge | ||
| postgres_exporter_config_last_reload_success_timestamp_seconds{supabase_project_ref="xdgggqomhgiilfjtepts",service_type="postgresql"} 0 |
There was a problem hiding this comment.
Do you know if this was manually created? Seems like this metric also references a timestamp?
There was a problem hiding this comment.
Discussed separately - this was not manually edited. Even though it references a timestamp, we can't use time_elapsed here since it regularly reports 0's.
* Supabase integration * Add initial release changelog * ddev validate ci --sync * add metric check * sync metadata * validate labeler * Overwrite default process start time metric * Added missed metrics * Override another default go metric a85eecf
What does this PR do?
Supabase implementation.
Separate PRs will be made for: