Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add family specific byte units #19252

Merged
merged 3 commits into from
Dec 12, 2024
Merged

add family specific byte units #19252

merged 3 commits into from
Dec 12, 2024

Conversation

rybarczykj
Copy link
Member

@rybarczykj rybarczykj commented Dec 11, 2024

What does this PR do?

GXP-2329

add units for bytes and bit which funnel into separate bytes families

Motivation

https://datadoghq.atlassian.net/wiki/spaces/GE/pages/2671673472/Splitting+bytes+families+disambiguation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@rybarczykj rybarczykj marked this pull request as ready for review December 11, 2024 18:10
@rybarczykj rybarczykj requested a review from a team as a code owner December 11, 2024 18:10
@steveny91 steveny91 enabled auto-merge December 12, 2024 20:29
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.24%. Comparing base (33be8d2) to head (e44d79e).
Report is 5 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
active_directory 86.36% <ø> (ø)
activemq 52.80% <ø> (ø)
activemq_xml 82.20% <ø> (ø)
amazon_msk 89.19% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
appgate_sdp 93.93% <ø> (ø)
arangodb 98.23% <ø> (ø)
argo_rollouts 90.00% <ø> (ø)
argo_workflows 87.87% <ø> (ø)
argocd 87.23% <ø> (ø)
aspdotnet 100.00% <ø> (ø)
avi_vantage 91.46% <ø> (ø)
aws_neuron 92.42% <ø> (ø)
azure_iot_edge 82.08% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 83.33% <ø> (ø)
cacti 87.90% <ø> (ø)
calico 84.61% <ø> (ø)
cassandra 66.66% <ø> (ø)
cert_manager 77.41% <ø> (ø)
cisco_aci 89.53% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
cloud_foundry_api 96.11% <ø> (ø)
cloudera 99.51% <ø> (ø)
cockroachdb 92.98% <ø> (ø)
consul 91.92% <ø> (ø)
coredns 95.65% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_base 89.31% <ø> (+0.03%) ⬆️
datadog_checks_dev 77.63% <ø> (ø)
datadog_checks_downloader 81.37% <ø> (+3.22%) ⬆️
datadog_cluster_agent 90.19% <ø> (ø)
dcgm 93.54% <ø> (ø)
ddev 87.31% <ø> (ø)
directory 96.46% <ø> (ø)
disk 90.86% <ø> (+1.42%) ⬆️
dns_check 93.81% <ø> (ø)
dotnetclr 80.64% <ø> (ø)
druid 97.70% <ø> (ø)
ecs_fargate 83.71% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
esxi 93.92% <ø> (ø)
etcd 95.56% <ø> (ø)
external_dns 89.28% <ø> (ø)
fluentd 84.21% <ø> (ø)
fluxcd 88.31% <ø> (ø)
fly_io 97.13% <ø> (ø)
foundationdb 83.83% <ø> (ø)
gitlab_runner 92.76% <ø> (ø)
glusterfs 80.00% <ø> (ø)
go_expvar 92.66% <ø> (ø)
gunicorn 92.16% <ø> (ø)
hazelcast 92.30% <ø> (ø)
hdfs_datanode 89.63% <ø> (ø)
hdfs_namenode 86.60% <ø> (ø)
hive 51.42% <ø> (ø)
hivemq 61.90% <ø> (ø)
http_check 94.25% <ø> (ø)
hudi ?
ibm_db2 86.29% <ø> (ø)
ibm_i 82.36% <ø> (ø)
ibm_mq 47.55% <ø> (ø)
ignite 46.66% <ø> (ø)
impala 97.97% <ø> (ø)
istio 77.86% <ø> (ø)
jboss_wildfly 47.36% <ø> (ø)
kafka 64.70% <ø> (ø)
karpenter 95.06% <ø> (ø)
kong 88.42% <ø> (ø)
kube_apiserver_metrics 97.75% <ø> (ø)
kube_controller_manager 97.88% <ø> (ø)
kube_dns 95.94% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 97.92% <ø> (ø)
kubeflow 93.22% <ø> (ø)
kubelet 91.09% <ø> (ø)
kubernetes_cluster_autoscaler 93.22% <ø> (ø)
kubernetes_state 89.49% <ø> (ø)
kubevirt_api 82.75% <ø> (ø)
kubevirt_controller 85.36% <ø> (ø)
kubevirt_handler 91.32% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
kyverno 82.27% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linkerd 84.70% <ø> (ø)
linux_proc_extras 96.20% <ø> (ø)
mapr 82.70% <ø> (ø)
mapreduce 81.99% <ø> (ø)
marathon 83.06% <ø> (ø)
mcache 93.48% <ø> (ø)
mesos_master 89.71% <ø> (ø)
mesos_slave 93.56% <ø> (ø)
nagios 89.01% <ø> (ø)
network 93.77% <ø> (ø)
nfsstat 95.20% <ø> (ø)
nginx 94.65% <ø> (ø)
nginx_ingress_controller 98.55% <ø> (ø)
nvidia_nim 93.10% <ø> (ø)
nvidia_triton 88.52% <ø> (ø)
openldap 96.33% <ø> (ø)
openmetrics 98.05% <ø> (ø)
openstack 55.11% <ø> (ø)
pdh_check 97.36% <ø> (ø)
pgbouncer 91.66% <ø> (ø)
php_fpm 90.45% <ø> (ø)
postfix 88.04% <ø> (ø)
powerdns_recursor 96.65% <ø> (ø)
presto 59.09% <ø> (ø)
process 85.99% <ø> (ø)
prometheus 94.17% <ø> (ø)
proxysql 98.97% <ø> (ø)
pulsar 100.00% <ø> (ø)
rethinkdb 98.27% <ø> (ø)
riak 99.21% <ø> (ø)
riakcs 88.82% <ø> (ø)
silk 93.82% <ø> (ø)
singlestore 90.81% <ø> (ø)
slurm 88.88% <ø> (ø)
snowflake 96.27% <ø> (ø)
solr 56.25% <ø> (ø)
spark 93.47% <ø> (+0.30%) ⬆️
squid 100.00% <ø> (ø)
ssh_check 92.20% <ø> (ø)
statsd 87.36% <ø> (ø)
strimzi 89.78% <ø> (ø)
supervisord 90.14% <ø> (ø)
system_core 92.52% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 90.72% <ø> (ø)
teleport 99.61% <ø> (ø)
temporal 100.00% <ø> (ø)
teradata 94.27% <ø> (ø)
tibco_ems 91.98% <ø> (ø)
tls 91.78% <ø> (ø)
torchserve 97.32% <ø> (ø)
traefik_mesh 76.75% <ø> (ø)
traffic_server 96.13% <ø> (ø)
twemproxy 79.45% <ø> (ø)
twistlock 80.41% <ø> (ø)
varnish 84.22% <ø> (ø)
vllm 93.10% <ø> (ø)
vsphere 96.60% <ø> (+0.31%) ⬆️
weaviate 76.27% <ø> (ø)
win32_event_log 82.55% <ø> (ø)
wmi_check 97.50% <ø> (ø)
yarn 89.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@steveny91 steveny91 added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit 2b4ddd8 Dec 12, 2024
388 of 390 checks passed
@steveny91 steveny91 deleted the jack/bytes-families-yay branch December 12, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants