Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTPLAT-393] DDSaaS: Authorize.Net: Crawler Integration v1.0.0 #19216

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

DhruvaPatel-crest
Copy link
Contributor

What does this PR do?

This is an initial release PR of Authorize.Net integration including all the required assets.

Motivation

Crawler code for this integration has been committed in its respective repo
Pipeline and Facet group created for this integration are available in our sandbox and would be shared separately with the required teams.
Samples for the pipeline review would also be shared separately with the required teams.
Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behavior.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@DhruvaPatel-crest DhruvaPatel-crest changed the title DDSaaS: Authorize.Net: Crawler Integration v1.0.0 [INTPLAT-393] DDSaaS: Authorize.Net: Crawler Integration v1.0.0 Dec 24, 2024
@DhruvaPatel-crest DhruvaPatel-crest marked this pull request as ready for review December 24, 2024 06:18
@DhruvaPatel-crest DhruvaPatel-crest requested review from a team as code owners December 24, 2024 06:18
@DhruvaPatel-crest DhruvaPatel-crest requested review from a team as code owners December 24, 2024 06:18
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; I've left some minor feedback per our style guide and also for consistency.

I've also suggested breaking the Generate Login ID and Transaction Key in Authorize.Net section into two sub-sections for the Login ID and Transaction Key. As a general guideline, keeping lists of numbered steps to 8 or less is helpful for user engagement.

Let me know if you have any questions or feedback!

authorize_net/README.md Outdated Show resolved Hide resolved
authorize_net/README.md Outdated Show resolved Hide resolved
authorize_net/README.md Outdated Show resolved Hide resolved
authorize_net/README.md Outdated Show resolved Hide resolved
authorize_net/README.md Outdated Show resolved Hide resolved
authorize_net/README.md Show resolved Hide resolved
authorize_net/README.md Outdated Show resolved Hide resolved
authorize_net/README.md Outdated Show resolved Hide resolved
authorize_net/metadata.csv Outdated Show resolved Hide resolved

### Metrics

The Authorize.Net integration collects and forward metrics to Datadog.
The Authorize.Net integration collects and forwards unsettled transaction metrics to Datadog.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected that the metrics in metadata.csv will be displayed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we are following this standard to list all the metrics ingested by this integration in the integration document.

Copy link
Contributor

@buraizu buraizu Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming. The metrics are currently not being displayed in a local build of the documentation. The get-metrics-from-git functionality seems to only work when authorize_net is used rather than authorize-net. I've left a suggestion above to update this line.

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying those changes. The metrics table is currently not being rendered in a local build of the documentation site, so I've left one additional suggestion to allow it to be properly rendered.

The Authorize.Net integration collects and forward metrics to Datadog.
The Authorize.Net integration collects and forwards unsettled transaction metrics to Datadog.

{{< get-metrics-from-git "authorize-net" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{< get-metrics-from-git "authorize-net" >}}
{{< get-metrics-from-git "authorize_net" >}}


### Metrics

The Authorize.Net integration collects and forward metrics to Datadog.
The Authorize.Net integration collects and forwards unsettled transaction metrics to Datadog.
Copy link
Contributor

@buraizu buraizu Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming. The metrics are currently not being displayed in a local build of the documentation. The get-metrics-from-git functionality seems to only work when authorize_net is used rather than authorize-net. I've left a suggestion above to update this line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants