-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INTPLAT-393] DDSaaS: Authorize.Net: Crawler Integration v1.0.0 #19216
base: master
Are you sure you want to change the base?
[INTPLAT-393] DDSaaS: Authorize.Net: Crawler Integration v1.0.0 #19216
Conversation
…grations-core into authorize_net-assets-v1.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR; I've left some minor feedback per our style guide and also for consistency.
I've also suggested breaking the Generate Login ID and Transaction Key in Authorize.Net
section into two sub-sections for the Login ID and Transaction Key. As a general guideline, keeping lists of numbered steps to 8 or less is helpful for user engagement.
Let me know if you have any questions or feedback!
|
||
### Metrics | ||
|
||
The Authorize.Net integration collects and forward metrics to Datadog. | ||
The Authorize.Net integration collects and forwards unsettled transaction metrics to Datadog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it expected that the metrics in metadata.csv
will be displayed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we are following this standard to list all the metrics ingested by this integration in the integration document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for confirming. The metrics are currently not being displayed in a local build of the documentation. The get-metrics-from-git
functionality seems to only work when authorize_net
is used rather than authorize-net
. I've left a suggestion above to update this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying those changes. The metrics table is currently not being rendered in a local build of the documentation site, so I've left one additional suggestion to allow it to be properly rendered.
authorize_net/README.md
Outdated
The Authorize.Net integration collects and forward metrics to Datadog. | ||
The Authorize.Net integration collects and forwards unsettled transaction metrics to Datadog. | ||
|
||
{{< get-metrics-from-git "authorize-net" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{< get-metrics-from-git "authorize-net" >}} | |
{{< get-metrics-from-git "authorize_net" >}} |
|
||
### Metrics | ||
|
||
The Authorize.Net integration collects and forward metrics to Datadog. | ||
The Authorize.Net integration collects and forwards unsettled transaction metrics to Datadog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for confirming. The metrics are currently not being displayed in a local build of the documentation. The get-metrics-from-git
functionality seems to only work when authorize_net
is used rather than authorize-net
. I've left a suggestion above to update this line.
What does this PR do?
This is an initial release PR of Authorize.Net integration including all the required assets.
Motivation
Crawler code for this integration has been committed in its respective repo
Pipeline and Facet group created for this integration are available in our sandbox and would be shared separately with the required teams.
Samples for the pipeline review would also be shared separately with the required teams.
Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behavior.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged