Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTPLAT-413] DDSaaS: Genesys: Crawler Integration v1.0.0 #19104

Merged

Conversation

avaid-crest
Copy link
Contributor

What does this PR do?

This is an initial release PR of Genesys integration including all the required assets.

Additional Notes

  • Crawler code for this integration has been committed in its respective repo.
  • Pipeline and Facet group created for this integration are available in our sandbox and would be shared separately with the required teams.
  • Samples for the pipeline review would also be shared separately with the required teams.
  • Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behaviour.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@avaid-crest avaid-crest marked this pull request as ready for review November 25, 2024 15:11
@avaid-crest avaid-crest requested review from a team as code owners November 25, 2024 15:11
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for drafting this, left some suggestions and comments on the monitor descriptions. Let me know if you have any questions!


[Genesys][1] is a comprehensive cloud-based contact center platform that enables businesses to manage and optimize customer interactions across multiple channels, including voice, chat, email, social media, and messaging. It's known for its flexibility, scalability, and integration capabilities, helping businesses improve customer experience and streamline operations.

The Genesys integration collects conversations (Voice, Email, Message, Callback, Chat) analytics metrics and audit logs and ingests them into Datadog for comprehensive analysis.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Genesys integration collects conversations (Voice, Email, Message, Callback, Chat) analytics metrics and audit logs and ingests them into Datadog for comprehensive analysis.
The Genesys integration collects analytics metrics and audit logs from conversations (voice, email, message, callback, chat) and ingests them into Datadog for comprehensive analysis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, audit logs refers to all the logs associated with the Genesys account and not conversation related logs.

Comment on lines 13 to 15
#### Get config parameters from Genesys

#### Steps to get Client ID and Client Secret
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the same level, but recommend choosing one instead of nesting.

Suggested change
#### Get config parameters from Genesys
#### Steps to get Client ID and Client Secret
#### Get Client ID and Client Secret config parameters from Genesys

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the changes as per your suggestion.


#### Steps to get Client ID and Client Secret
1. Login to your [Genesys account][2] with **Admin** role.
2. [Add a new role][3] with below permissions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. [Add a new role][3] with below permissions:
2. [Add a new role][3] with the following permissions:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the changes as per your suggestion.

1. Analytics > Conversation Aggregate > View (Query for conversation aggregates)
2. Analytics > Conversation Detail > View (Query for conversation Details)
3. Audits > Audit > View (View audits)
3. Ensure the role created in step 2 is assigned to the logged-in user. (Refer to the [guide on assigning roles to users][4])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Ensure the role created in step 2 is assigned to the logged-in user. (Refer to the [guide on assigning roles to users][4])
3. Ensure the role created in the previous step is assigned to the logged-in user. For more information on assigning roles to users, see the Genesys guide to [Assign roles, divisions, licenses, and add-ons][4].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been added as per your suggestion.

"created_at": "2024-11-18",
"last_updated_at": "2024-11-18",
"title": "High Number of Abandoned Outbound Conversations Detected",
"description": "High number of abandoned outbound conversations detected monitor detecting a significant increase in outbound conversations that were abandoned before completion.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add more context to the description? For more information and examples, see the Best practice guide. At a minimum:

  • This is not a copy of the title.
  • Define the problem stated by the title.
  • Answer why this is an issue worth alerting on.
  • Describe the impact of the problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified the description as per the above factors.

"created_at": "2024-11-18",
"last_updated_at": "2024-11-18",
"title": "High Number of Errored Conversations Detected",
"description": "High number of errored conversations detected monitor tracking a high occurrence of conversations ending with errors, indicating potential system or process issues.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here for more context in the description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified the description.

"created_at": "2024-11-18",
"last_updated_at": "2024-11-18",
"title": "High Number of over SLA Conversations Detected",
"description": "High number of over SLA conversations detected monitor alert for an increased count of conversations exceeding the SLA threshold, potentially impacting response time and service levels.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment to add more context to the description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified the description.

"created_at": "2024-11-18",
"last_updated_at": "2024-11-18",
"title": "High Number of State Transition Errors Detected",
"description": "High number of state transition errors detected monitor detecting an elevated count of state transition errors, indicating potential issues in process transitions or workflow continuity.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment to add more context to the description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified the description as per your suggestion.

@avaid-crest avaid-crest requested a review from a team as a code owner November 26, 2024 13:16
@torosmassa torosmassa changed the title DDSaaS: Genesys: Crawler Integration v1.0.0 [INTPLAT-413] DDSaaS: Genesys: Crawler Integration v1.0.0 Dec 11, 2024
@avaid-crest avaid-crest requested a review from a team as a code owner December 16, 2024 10:29
@nathanmadams nathanmadams added this pull request to the merge queue Jan 6, 2025
Merged via the queue into DataDog:master with commit d51bcbe Jan 6, 2025
38 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
* Genesys Crawler integration with assets

* Resolved metadata checks error

* Added changes in genesys_tests.yaml file

* Resolved checks error for metadata

* Resolved pipeline checks error

* Updated dashboards

* Added changes as per modified assets

* Added changes as per review comments

* Added readme changes d51bcbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants