-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDMII-3147] update Cisco IP SLA metrics #19046
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3bcfa27
to
429e7bd
Compare
f0210fa
to
a4885c6
Compare
0: other | ||
1: ok | ||
2: disconnected | ||
3: overThreshold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥜 nitpick: I think we should write these in snake case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
af0fb42
to
44f2525
Compare
44f2525
to
c763414
Compare
What does this PR do?
This PR adds some tags on existing Cisco IP SLA metrics and update their description which was not clear enough.
Motivation
Some customers wants us to support Cisco IP SLA but we already have some metrics in our _cisco-generic profile, so updating the description will hopefully make them for visible
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged