Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDMII-3147] update Cisco IP SLA metrics #19046

Closed
wants to merge 5 commits into from
Closed

Conversation

jedupau
Copy link
Contributor

@jedupau jedupau commented Nov 13, 2024

What does this PR do?

This PR adds some tags on existing Cisco IP SLA metrics and update their description which was not clear enough.

Motivation

Some customers wants us to support Cisco IP SLA but we already have some metrics in our _cisco-generic profile, so updating the description will hopefully make them for visible

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.45%. Comparing base (6daceec) to head (af0fb42).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
snmp 95.64% <80.00%> (-0.09%) ⬇️
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@jedupau jedupau force-pushed the jed/cisco-ipsla branch 4 times, most recently from f0210fa to a4885c6 Compare November 18, 2024 16:24
@jedupau jedupau changed the title [NDMII-3147] add ipsla profile [NDMII-3147] update Cisco IP SLA metrics Nov 18, 2024
@jedupau jedupau marked this pull request as ready for review November 18, 2024 16:24
@jedupau jedupau requested review from a team as code owners November 18, 2024 16:24
steveny91
steveny91 previously approved these changes Nov 18, 2024
0: other
1: ok
2: disconnected
3: overThreshold
Copy link
Contributor

@TCheruy TCheruy Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥜 nitpick: ‏ I think we should write these in snake case

TCheruy
TCheruy previously approved these changes Nov 18, 2024
Copy link
Contributor

@TCheruy TCheruy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@jedupau jedupau force-pushed the jed/cisco-ipsla branch 3 times, most recently from af0fb42 to 44f2525 Compare November 18, 2024 17:41
@jedupau jedupau requested review from a team as code owners November 18, 2024 17:41
@jedupau jedupau removed request for a team November 18, 2024 17:45
@jedupau jedupau closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment