Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vonage:Assets PR #19012

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Vonage:Assets PR #19012

wants to merge 42 commits into from
+1,341 −34

Conversation

yogesh-s-modak
Copy link

What does this PR do?

PR includes skeleton of Vonage integration including all assets like dashboards, image, README content, etc.

Motivation

This is beta release of crawler integration and is intended for internal testing before going live.

Additional Notes

Only crawler-based integration related changes are included in this PR.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@yogesh-s-modak yogesh-s-modak requested review from a team as code owners November 7, 2024 10:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

gunterd
gunterd reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@gunterd gunterd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should get the logs pipeline validation working.

vonage/assets/logs/vonage.yaml Outdated Show resolved Hide resolved
vonage/assets/logs/vonage.yaml Outdated Show resolved Hide resolved
vonage/assets/logs/vonage.yaml Outdated Show resolved Hide resolved
vonage/assets/logs/vonage.yaml Outdated Show resolved Hide resolved
vonage/assets/logs/vonage.yaml Outdated Show resolved Hide resolved
vonage/assets/logs/vonage.yaml Outdated Show resolved Hide resolved
vonage/assets/logs/vonage.yaml Outdated Show resolved Hide resolved
vonage/assets/logs/vonage.yaml Outdated Show resolved Hide resolved
vonage/assets/logs/vonage.yaml Outdated Show resolved Hide resolved
vonage/assets/logs/vonage.yaml Outdated Show resolved Hide resolved
@datadog-agent-integrations-bot
Copy link
Contributor

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@datadog-agent-integrations-bot
Copy link
Contributor

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@datadog-agent-integrations-bot
Copy link
Contributor

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@yogesh-s-modak yogesh-s-modak requested a review from a team as a code owner November 27, 2024 07:06
cswatt
cswatt previously approved these changes Dec 6, 2024
View reviewed changes
@capucinemartin capucinemartin added the assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging label Dec 18, 2024
@capucinemartin capucinemartin added assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging and removed assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging labels Dec 30, 2024
capucinemartin
capucinemartin reviewed Dec 30, 2024
View reviewed changes
vonage/assets/logs/vonage_tests.yaml
-
sample: |-
{
"country" : "IN",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this integration and it seems fine, however could we have error_code_description, product, error_code and latency as a tag (under ddtags) so it's testing the remappers

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Have made the changes in the latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capucinemartin capucinemartin capucinemartin left review comments

@gunterd gunterd gunterd left review comments

@aliciascott aliciascott aliciascott left review comments

@cswatt cswatt cswatt left review comments

@iliakur iliakur iliakur left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
agent/approved assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging changelog/no-changelog docs/review-requested documentation ecosystems/review-requested integration/vonage product/review-requested qa/skip-qa Automatically skip this PR for the next QA release team/documentation team/logs-backend team/saas-integrations team/siem-logs-reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yogesh-s-modak @iliakur @cswatt @gunterd @aliciascott @capucinemartin