Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEMINT-123] DDSaaS: incident.io: Integration v1.0.0 #18595

Merged
merged 22 commits into from
Nov 15, 2024

Conversation

mauneelsorathia-crest
Copy link
Contributor

@mauneelsorathia-crest mauneelsorathia-crest commented Sep 16, 2024

What does this PR do?

This is a initial release PR of incident.io integration including all the required assets i.e. Pipeline, Dashboard and Monitors.

Additional Notes

  • This integration is webhook based and so Crawler will not be used.
  • Datadog team will be required to add UI component for generation of webhook URL in the configuration tile. The ddsource query param should be 'incident-io'.
  • The assets are available in our sandbox and can be shared separately with the required teams.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

incident_io/manifest.json Outdated Show resolved Hide resolved
#### Webhook configuration
Configure the Datadog endpoint to forward events of incident.io incidents as logs to Datadog. For more details, see the incident.io [webhooks][2] documentation.

1. Select an existing API key or create a new one by clicking one of the buttons below: <!-- UI Component to be added by Datadog team -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the backstory is to this placeholder, but do we just want users to generate a Datadog API key here? If so, we can link them to https://app.datadoghq.com/organization-settings/api-keys.

Copy link
Contributor

@gunterd gunterd Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've actually taken care of this in this task. I updated the configuration tab to match our other webhooks integrations.

@gunterd
Copy link
Contributor

gunterd commented Nov 6, 2024

@jnhunsberger for PM review

@MatthewMSaucedo MatthewMSaucedo added assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging and removed assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging labels Nov 8, 2024
@gunterd gunterd enabled auto-merge November 15, 2024 09:14
@gunterd gunterd added this pull request to the merge queue Nov 15, 2024
Merged via the queue into DataDog:master with commit e820982 Nov 15, 2024
56 of 57 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 15, 2024
* Added incident.io integration assets

* Removed saved views from manifest

* Resolved log pipeline tests check failure

* Fixed pipeline tests file identation

* Changed tab spacing of pipeline tests yaml

* Changed tab spacing of pipeline tests yaml

* Reformatted pipeline tests file

* Reformatted pipeline tests file

* Fixed identation

* log sample fixed

* log sample fixed

* Updated README and monitor descriptions

* incorporated PR review suggestions

* Update critical_public_incident.json

* Update high_number_of_public_incidents.json

* Update public_incident_reopened.json

* Clean up monitor names

---------

Co-authored-by: Bhavik Parmar <[email protected]>
Co-authored-by: Bhavik Parmar <[email protected]>
Co-authored-by: Chris Laverdiere <[email protected]>
Co-authored-by: Chris Laverdiere <[email protected]>
Co-authored-by: Doug Gunter <[email protected]> e820982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants