-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of 'six' package from most tests (and haproxy and istio) #18593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datadog-agent-integrations-bot
bot
added
integration/consul
integration/disk
integration/dns_check
integration/elastic
integration/go_expvar
integration/haproxy
integration/hdfs_datanode
integration/hdfs_namenode
integration/istio
integration/kubelet
integration/lighttpd
integration/mapreduce
integration/mesos_master
integration/mesos_slave
integration/network
integration/openstack
integration/postfix
integration/postgres
integration/process
integration/redisdb
integration/snmp
integration/system_core
integration/vsphere
labels
Sep 16, 2024
datadog-agent-integrations-bot
bot
added
integration/ibm_mq
integration/openstack_controller
integration/tls
integration/mapr
integration/clickhouse
integration/amazon_msk
dev_package
team/container-integrations
base_package
integration/esxi
team/agent-integrations
team/network-device-monitoring
team/windows-agent
labels
Sep 16, 2024
iliakur
changed the title
Remove use of 'six' package from most tests
Remove use of 'six' package from most tests (and haproxy and istio)
Sep 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
steveny91
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
base_package
changelog/no-changelog
dev_package
integration/amazon_msk
integration/clickhouse
integration/consul
integration/disk
integration/dns_check
integration/elastic
integration/esxi
integration/go_expvar
integration/haproxy
integration/hdfs_datanode
integration/hdfs_namenode
integration/ibm_mq
integration/istio
integration/kubelet
integration/lighttpd
integration/mapr
integration/mapreduce
integration/mesos_master
integration/mesos_slave
integration/network
integration/openstack_controller
integration/openstack
integration/postfix
integration/postgres
integration/process
integration/redisdb
integration/snmp
integration/system_core
integration/tls
integration/vault
integration/vsphere
integration/yarn
integration/zk
team/agent-integrations
team/container-integrations
team/database-monitoring-agent
team/network-device-monitoring
team/platform-integrations
team/windows-agent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Started out by removing
six
from HA Proxy and Istio, then realized it's more incremental to remove it from tests first. So then I focused on that.Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged