Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate agent host tags for sqlserver #18557

Merged
merged 12 commits into from
Oct 1, 2024

Conversation

natashadada
Copy link
Contributor

What does this PR do?

In #18269 and DataDog/datadog-agent#28027, I added functions to get the host tags of the agent host. This PR updates the agent host tags that we use in the sqlserver integration. This change only affects customers with the propagate_agent_tags flag set to true. By calling get_agent_host_tags, we not only use the tags in the conf.yaml file but also other tags on the agent host.

Motivation

Metrics emitted by DBM integrations (postgres, sql server, and mysql) are tagged with the tags from the database instance host. We would like to update the propagate_agent_tags option (default false) that allows us to also consider the tags of the agent host. If this setting is enabled, we will propagate all agent host tags. This allows user to opt-in to having their postgres metrics tagged with the agent host tags.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@natashadada natashadada force-pushed the natasha.dada/sqlserver-propagate-tags branch from 758018e to c8f5fae Compare September 10, 2024 18:56
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.89%. Comparing base (fcbaaa1) to head (0126582).
Report is 3 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 84.80% <90.00%> (+4.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@natashadada natashadada force-pushed the natasha.dada/sqlserver-propagate-tags branch from 7a037d4 to 6a177d5 Compare September 23, 2024 13:52
@natashadada natashadada force-pushed the natasha.dada/sqlserver-propagate-tags branch from 590e9f2 to 3e8f057 Compare September 30, 2024 01:39
@natashadada natashadada merged commit d1279f7 into master Oct 1, 2024
49 of 50 checks passed
@natashadada natashadada deleted the natasha.dada/sqlserver-propagate-tags branch October 1, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants