-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate agent host tags for sqlserver #18557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natashadada
force-pushed
the
natasha.dada/sqlserver-propagate-tags
branch
from
September 10, 2024 18:56
758018e
to
c8f5fae
Compare
natashadada
force-pushed
the
natasha.dada/sqlserver-propagate-tags
branch
from
September 23, 2024 13:52
7a037d4
to
6a177d5
Compare
natashadada
force-pushed
the
natasha.dada/sqlserver-propagate-tags
branch
from
September 30, 2024 01:39
590e9f2
to
3e8f057
Compare
lu-zhengda
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In #18269 and DataDog/datadog-agent#28027, I added functions to get the host tags of the agent host. This PR updates the agent host tags that we use in the sqlserver integration. This change only affects customers with the
propagate_agent_tags
flag set to true. By callingget_agent_host_tags
, we not only use the tags in the conf.yaml file but also other tags on the agent host.Motivation
Metrics emitted by DBM integrations (postgres, sql server, and mysql) are tagged with the tags from the database instance host. We would like to update the
propagate_agent_tags
option (default false) that allows us to also consider the tags of the agent host. If this setting is enabled, we will propagate all agent host tags. This allows user to opt-in to having their postgres metrics tagged with the agent host tags.Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged