Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLINT-469] Add Octopus Deploy integration #18488

Open
wants to merge 53 commits into
base: master
Choose a base branch
from

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

Adds an integration for octopus deploy

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@datadog-agent-integrations-bot datadog-agent-integrations-bot bot added documentation release qa/skip-qa Automatically skip this PR for the next QA labels Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 97.92244% with 15 lines in your changes missing coverage. Please review.

Project coverage is 89.32%. Comparing base (50589cb) to head (e0312a0).
Report is 284 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
aerospike ?
airflow ?
appgate_sdp ?
cassandra ?
cassandra_nodetool ?
ceph ?
cilium ?
clickhouse ?
couchbase ?
dotnetclr ?
elastic ?
exchange_server ?
gearmand ?
gitlab ?
glusterfs ?
haproxy ?
hive ?
hivemq ?
ibm_ace ?
ibm_was ?
ignite ?
iis ?
jboss_wildfly ?
kafka ?
kafka_consumer ?
kubeflow ?
kubevirt_api ?
kubevirt_controller ?
kubevirt_handler ?
marklogic ?
mongo ?
mysql ?
octopus_deploy 97.92% <97.92%> (?)
openstack_controller ?
pdh_check ?
postgres ?
presto ?
sap_hana ?
scylla ?
snmp ?
solr ?
sonarqube ?
sqlserver ?
vault ?
vertica ?
voltdb ?
windows_performance_counters ?
windows_service ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Sep 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

github-actions bot commented Sep 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

github-actions bot commented Sep 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

github-actions bot commented Sep 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@sarah-witt sarah-witt changed the title Add Octopus Deploy integration [PLINT-469] Add Octopus Deploy integration Sep 3, 2024

### Configuration

1. Edit the `octopus_deploy.d/conf.yaml` file, in the `conf.d/` folder at the root of your Agent's configuration directory to start collecting your octopus_deploy performance data. See the [sample octopus_deploy.d/conf.yaml][4] for all available configuration options.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Edit the `octopus_deploy.d/conf.yaml` file, in the `conf.d/` folder at the root of your Agent's configuration directory to start collecting your octopus_deploy performance data. See the [sample octopus_deploy.d/conf.yaml][4] for all available configuration options.
1. Edit the `octopus_deploy.d/conf.yaml` file in the `conf.d/` folder at the root of your Agent's configuration directory to start collecting your `octopus_deploy` performance data. See the [sample `octopus_deploy.d/conf.yaml`][4] for all available configuration options.

Comment on lines 7 to 10
Include a high level overview of what this integration does:
- What does your product do (in 1-2 sentences)?
- What value will customers get from this integration, and why is it valuable to them?
- What specific data will your integration monitor, and what's the value of that data?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be replaced with actual content

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks!

Comment on lines 43 to 45
The Octopus Deploy integration does not include any service checks.

See [service_checks.json][8] for a list of service checks provided by this integration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These appear to be at odds with each other. Which is correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed one!

required: true
- name: project_groups
description: |
filter your integration by project groups and projects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
filter your integration by project groups and projects.
Filter your integration by project groups and projects.

HadhemiDD
HadhemiDD previously approved these changes Oct 21, 2024
HadhemiDD
HadhemiDD previously approved these changes Oct 24, 2024
* Fix new deployment logic and support in progress and queued deployments

* sync metadata

* update caddyfile

* fix

* add to completed date

* Refactor

* fixed e2e tests

* fixed instance fixture

* fixed e2e test

* added some e2e asserts

* fixed lint error

* all metrics asserted

* Add test asserting metadata, add test and handle failure of tasks

* store base tags

* Don't report completed and executing metrics if no data

* Add support for octopus server node metrics

* remove unused constants

* validate

* lint

* update e2e

* update metadata

* Use project name and project group name tags

* Use space name instead of space id

* Update log lines

* update test instance

* Update metric description

---------

Co-authored-by: Jose Manuel Almaza <[email protected]>
* Add support for deployment logs

* Add server node tag

* add e2e_metrics

* remove completed_time

* Address comments

* add extra assert
* Add support for pagination

* update caddyfile and remove unneeded args

* Apply suggestions
…nment, deployment, and release (#19192)

* Add support for environment metrics

* Add config for autodiscovery

* Add support for environments via discovery

* Add environment, release, and deployment tags

* Add caching for environments, releases, and deployments

* add to caddyfile

* remove env fallback

* change environments cache to dictionary

* use tuple for deployment

* Add pagination for environments

* update caddyfile

* update environments config

* sync models

* Filter by environment

* only collect deploy tasks

* update caddyfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants