Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs8718/update azure ad #18423

Merged
merged 13 commits into from
Nov 26, 2024
Merged

Docs8718/update azure ad #18423

merged 13 commits into from
Nov 26, 2024
+15 −17

Conversation

buraizu
Copy link
Contributor

@buraizu buraizu commented Aug 26, 2024

What does this PR do?

Rename Azure AD to Microsoft Entra ID

Motivation

DOCS-8718

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@buraizu buraizu requested review from a team as code owners August 26, 2024 22:34
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

neko-dd
neko-dd reviewed Aug 27, 2024
View reviewed changes
microsoft_entra_id/README.md Outdated
@@ -75,7 +73,7 @@ You can view these events in [Event Explorer][5].

Need help? Contact [Datadog support][4].

[1]: https://docs.microsoft.com/en-us/azure/active-directory/reports-monitoring/overview-reports#activity-reports
[1]: https://docs.microsoft.com/azure/active-directory/reports-monitoring/overview-reports#activity-reports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be https://learn.microsoft.com/entra/identity/monitoring-health/overview-monitoring-health#activity-reports ?

microsoft_entra_id/README.md Outdated
@@ -75,7 +73,7 @@ You can view these events in [Event Explorer][5].

Need help? Contact [Datadog support][4].

[1]: https://docs.microsoft.com/en-us/azure/active-directory/reports-monitoring/overview-reports#activity-reports
[1]: https://docs.microsoft.com/azure/active-directory/reports-monitoring/overview-reports#activity-reports
[2]: https://docs.datadoghq.com/logs/guide/azure-logging-guide/
[3]: https://docs.microsoft.com/en-us/azure/active-directory/reports-monitoring/tutorial-azure-monitor-stream-logs-to-event-hub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be https://learn.microsoft.com/entra/identity/monitoring-health/howto-stream-logs-to-event-hub ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the best option, thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you replaced link 1 with this when I had been intending link 3. I suggested a different link for link 1, in another comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying, updated

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@buraizu buraizu requested a review from neko-dd August 29, 2024 17:37
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

neko-dd
neko-dd previously approved these changes Aug 30, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@buraizu buraizu requested a review from neko-dd November 26, 2024 00:32
@buraizu buraizu added this pull request to the merge queue Nov 26, 2024
Merged via the queue into master with commit 74defa8 Nov 26, 2024
37 of 38 checks passed
@buraizu buraizu deleted the docs8718/update-azure-ad branch November 26, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neko-dd neko-dd neko-dd approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog docs/approved documentation ecosystems/review-requested integration/azure_active_directory product/review-requested qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations team/documentation team/logs-backend team/siem-logs-reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buraizu @neko-dd