-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add apiserver_admission_webhook_request_total metric #17690
feat: add apiserver_admission_webhook_request_total metric #17690
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
aacc541
to
5d16a39
Compare
@FlorentClarret I don't understand what is wrong with the tests. Can you help me? |
Would anyone be able to help me with this PR? @Kyle-Neale, @jmeunier28, @dkirov-dd or someone else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
I think the metric does in fact make sense and sounds useful, and the PR itself looks good to me. I added one small suggestion, to add the metric stability level and supported k8s version to the documentation, but otherwise I am happy to approve this afterwards
kube_apiserver_metrics/datadog_checks/kube_apiserver_metrics/kube_apiserver_metrics.py
Show resolved
Hide resolved
Co-authored-by: Steven Blumenthal <[email protected]>
What does this PR do?
This PR adds a new kubernetes metric:
apiserver_admission_webhook_request_total
More details: https://kubernetes.io/docs/reference/instrumentation/metrics/
This metric was created in the kubernetes 1.23 version: kubernetes/kubernetes#103162
Fix: #17689
Motivation
This metric is missing in the Datadog Kubernetes integration.
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged