-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of helper for creating logs saved views #17353
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Test Results 853 files 853 suites 5h 54m 22s ⏱️ For more details on these failures, see this check. Results for commit a8213cc. ♻️ This comment has been updated with latest results. |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* First version of helper for creating logs saved views * add changelog * Drop trivial subfunction, add docs 6740c11
What does this PR do?
First take on a script to create saved views. Was used for the following 2 PRs:
Motivation
Too much manual work without a script.
Additional Notes
The part that worries me is that there's no clear definition of what a saved view asset should look like.
I based my manipulations on examples and feedback from validations, but it would be nice to find an actual schema.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged