Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of helper for creating logs saved views #17353

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Apr 4, 2024

What does this PR do?

First take on a script to create saved views. Was used for the following 2 PRs:

Motivation

Too much manual work without a script.

Additional Notes

The part that worries me is that there's no clear definition of what a saved view asset should look like.
I based my manipulations on examples and feedback from validations, but it would be nice to find an actual schema.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 24 lines in your changes missing coverage. Please review.

Project coverage is 90.69%. Comparing base (21d0d70) to head (a8213cc).
Report is 1248 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
btrfs 82.91% <ø> (ø)
cassandra ?
cassandra_nodetool 93.16% <ø> (ø)
ceph 91.07% <ø> (ø)
cilium 77.72% <ø> (+0.87%) ⬆️
clickhouse 95.65% <ø> (ø)
cloudera 99.49% <ø> (ø)
confluent_platform ?
coredns 94.61% <ø> (ø)
couchbase 85.26% <ø> (+0.36%) ⬆️
datadog_checks_downloader 81.40% <ø> (ø)
ddev 88.17% <33.33%> (-0.22%) ⬇️
dns_check 93.33% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
elastic 93.36% <ø> (ø)
envoy 95.34% <ø> (+0.48%) ⬆️
etcd 95.56% <ø> (ø)
external_dns 89.28% <ø> (ø)
foundationdb 83.83% <ø> (ø)
gearmand 78.26% <ø> (+1.24%) ⬆️
gitlab 91.95% <ø> (+1.00%) ⬆️
go_expvar 92.73% <ø> (ø)
haproxy 95.13% <ø> (+0.16%) ⬆️
harbor 89.65% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hdfs_datanode 89.74% <ø> (ø)
hdfs_namenode 86.72% <ø> (ø)
hive ?
hivemq ?
http_check 95.32% <ø> (+2.02%) ⬆️
hudi ?
ibm_ace 92.25% <ø> (ø)
ibm_mq 91.28% <ø> (ø)
ignite ?
jboss_wildfly ?
kafka ?
kafka_consumer 93.07% <ø> (ø)
kong 87.62% <ø> (ø)
kube_dns 95.97% <ø> (ø)
kubelet 91.01% <ø> (ø)
linkerd 85.22% <ø> (+1.13%) ⬆️
mapreduce 82.12% <ø> (ø)
mesos_master 89.75% <ø> (ø)
mesos_slave 93.33% <ø> (ø)
mongo 96.19% <ø> (?)
mysql 87.81% <ø> (?)
network 93.65% <ø> (+1.08%) ⬆️
nfsstat 95.20% <ø> (ø)
openstack_controller 93.89% <ø> (ø)
oracle 88.33% <ø> (ø)
pdh_check 95.65% <ø> (ø)
php_fpm 90.53% <ø> (+0.82%) ⬆️
postgres 93.07% <ø> (ø)
powerdns_recursor 96.65% <ø> (ø)
presto ?
rabbitmq 95.73% <ø> (ø)
ray 96.45% <ø> (ø)
redisdb 88.07% <ø> (ø)
riak 99.21% <ø> (ø)
riakcs 93.61% <ø> (ø)
sap_hana 91.37% <ø> (ø)
snmp 95.76% <ø> (?)
solr 56.25% <ø> (ø)
sonarqube 98.24% <ø> (ø)
spark 94.14% <ø> (ø)
sqlserver 89.98% <ø> (+0.03%) ⬆️
ssh_check 91.58% <ø> (ø)
statsd 87.36% <ø> (ø)
teradata 94.05% <ø> (ø)
tomcat 60.41% <ø> (?)
varnish 84.39% <ø> (+0.26%) ⬆️
weblogic 71.73% <ø> (ø)
win32_event_log 86.36% <ø> (ø)
windows_performance_counters 98.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Apr 4, 2024

Test Results

   853 files     853 suites   5h 54m 22s ⏱️
 6 416 tests  6 227 ✅   188 💤 1 ❌
27 098 runs  22 447 ✅ 4 650 💤 1 ❌

For more details on these failures, see this check.

Results for commit a8213cc.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 5, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

HadhemiDD
HadhemiDD previously approved these changes May 15, 2024
Copy link
Contributor

@HadhemiDD HadhemiDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dd-devflow dd-devflow bot closed this Oct 5, 2024
@dd-devflow dd-devflow bot deleted the ik/saved-views-helper branch October 5, 2024 00:00
@iliakur iliakur restored the ik/saved-views-helper branch December 18, 2024 12:24
@iliakur iliakur reopened this Dec 18, 2024
@iliakur iliakur merged commit 6740c11 into master Dec 18, 2024
249 of 254 checks passed
@iliakur iliakur deleted the ik/saved-views-helper branch December 18, 2024 12:38
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
* First version of helper for creating logs saved views

* add changelog

* Drop trivial subfunction, add docs 6740c11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants