-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release datadog_checks_dev #17243
Release datadog_checks_dev #17243
Conversation
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small suggestions for consistency and fix a typo
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
The |
1 similar comment
The |
Co-authored-by: May Lee <[email protected]>
The |
The |
Test Results 1 036 files 1 036 suites 6h 38m 59s ⏱️ Results for commit fadf2c0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
about the CI error:
- we install datadog_checks_dev 32.0.0 from source
- we install ddev from source, which depends on datadog_checks_dev 31, so the local version does not satisfy the requirement, so we get the wheel from PyPi, with the old version of this validation
so you'll need to bump the version in ddev right after dcd gets released
--------- Co-authored-by: May Lee <[email protected]> 1a291c3
What does this PR do?
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.