Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release datadog_checks_dev #17243

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Release datadog_checks_dev #17243

merged 5 commits into from
Mar 22, 2024

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Mar 21, 2024

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@iliakur iliakur requested review from a team as code owners March 21, 2024 16:02
@iliakur iliakur changed the title ik/release dcd Release datadog_checks_dev Mar 21, 2024
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small suggestions for consistency and fix a typo

datadog_checks_dev/CHANGELOG.md Outdated Show resolved Hide resolved
datadog_checks_dev/CHANGELOG.md Outdated Show resolved Hide resolved
datadog_checks_dev/CHANGELOG.md Outdated Show resolved Hide resolved
datadog_checks_dev/CHANGELOG.md Outdated Show resolved Hide resolved
datadog_checks_dev/CHANGELOG.md Outdated Show resolved Hide resolved
datadog_checks_dev/CHANGELOG.md Outdated Show resolved Hide resolved
datadog_checks_dev/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (bec14d6) to head (fadf2c0).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq 52.80% <ø> (ø)
activemq_xml 82.31% <ø> (∅)
aerospike 87.17% <ø> (+0.32%) ⬆️
airflow 92.20% <ø> (ø)
ambari 85.80% <ø> (ø)
arangodb 98.23% <ø> (ø)
argo_rollouts 90.00% <ø> (ø)
argo_workflows 87.87% <ø> (ø)
argocd 87.81% <ø> (ø)
avi_vantage 91.35% <ø> (ø)
azure_iot_edge 82.08% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 82.91% <ø> (ø)
calico 84.61% <ø> (ø)
cassandra 66.66% <ø> (ø)
cassandra_nodetool 93.16% <ø> (ø)
ceph 91.07% <ø> (ø)
cilium 77.72% <ø> (+0.87%) ⬆️
cisco_aci 95.31% <ø> (ø)
clickhouse 95.65% <ø> (ø)
cloud_foundry_api 96.11% <ø> (ø)
cloudera 99.49% <ø> (ø)
cockroachdb 93.19% <ø> (ø)
confluent_platform 81.96% <ø> (ø)
couch 94.50% <ø> (+0.23%) ⬆️
couchbase 84.89% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_dev 77.41% <100.00%> (+0.03%) ⬆️
datadog_checks_downloader 81.40% <ø> (ø)
datadog_cluster_agent 90.19% <ø> (ø)
dcgm 92.10% <ø> (ø)
ddev 88.37% <ø> (-0.02%) ⬇️
directory 95.68% <ø> (+0.43%) ⬆️
disk 91.47% <ø> (+2.13%) ⬆️
dns_check 93.33% <ø> (ø)
dotnetclr 91.39% <ø> (+12.90%) ⬆️
ecs_fargate 83.52% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
elastic 93.36% <ø> (ø)
envoy 95.34% <ø> (+0.29%) ⬆️
exchange_server 96.85% <ø> (+11.81%) ⬆️
external_dns 89.28% <ø> (ø)
fluxcd 88.31% <ø> (ø)
foundationdb 83.83% <ø> (ø)
gearmand 78.26% <ø> (+1.24%) ⬆️
gitlab 91.95% <ø> (+1.00%) ⬆️
gitlab_runner 92.10% <ø> (ø)
glusterfs 80.09% <ø> (+0.90%) ⬆️
go_expvar 92.73% <ø> (ø)
haproxy 95.13% <ø> (+0.16%) ⬆️
harbor 89.65% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hive 51.42% <ø> (ø)
hivemq 61.90% <ø> (ø)
http_check 95.32% <ø> (+2.02%) ⬆️
hudi 73.91% <ø> (?)
ibm_ace 91.91% <ø> (ø)
ibm_db2 95.16% <ø> (ø)
ibm_i 81.91% <ø> (ø)
ibm_was 96.08% <ø> (ø)
ignite 46.66% <ø> (ø)
iis 95.05% <ø> (ø)
impala 97.97% <ø> (ø)
jboss_wildfly 47.36% <ø> (ø)
kafka 64.70% <ø> (ø)
kafka_consumer 93.07% <ø> (ø)
karpenter 94.36% <ø> (ø)
kong 87.62% <ø> (ø)
kube_apiserver_metrics 97.74% <ø> (ø)
kube_controller_manager 97.89% <ø> (ø)
kube_dns 95.97% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 97.92% <ø> (ø)
kubelet 90.99% <ø> (ø)
kubernetes_state 89.50% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
linux_proc_extras 96.22% <ø> (∅)
mapr 82.42% <ø> (ø)
marathon 83.12% <ø> (ø)
marklogic 96.09% <ø> (ø)
mcache 93.50% <ø> (ø)
mesos_slave 93.33% <ø> (ø)
mongo 96.21% <ø> (ø)
mysql 87.84% <ø> (ø)
nagios 89.01% <ø> (ø)
network 93.11% <ø> (+0.54%) ⬆️
nginx 95.07% <ø> (+0.53%) ⬆️
nginx_ingress_controller 98.36% <ø> (ø)
nvidia_triton 88.52% <ø> (ø)
oracle 88.54% <ø> (ø)
pdh_check 95.65% <ø> (ø)
php_fpm 90.53% <ø> (+0.82%) ⬆️
postgres 92.97% <ø> (+<0.01%) ⬆️
presto 59.09% <ø> (ø)
process 85.28% <ø> (+0.28%) ⬆️
prometheus 94.17% <ø> (ø)
pulsar 100.00% <ø> (ø)
rabbitmq 95.73% <ø> (ø)
redisdb 88.07% <ø> (ø)
riakcs 93.61% <ø> (ø)
sap_hana 91.37% <ø> (ø)
scylla 98.29% <ø> (ø)
silk 93.82% <ø> (ø)
snmp 95.76% <ø> (+0.04%) ⬆️
snowflake 96.27% <ø> (ø)
solr 56.25% <ø> (ø)
sonarqube 98.24% <ø> (ø)
spark 94.14% <ø> (+0.27%) ⬆️
sqlserver 89.90% <ø> (+1.29%) ⬆️
ssh_check 91.58% <ø> (ø)
statsd 87.36% <ø> (ø)
system_core 92.66% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 92.92% <ø> (+1.34%) ⬆️
teamcity 88.74% <ø> (+3.21%) ⬆️
teradata 94.05% <ø> (ø)
tokumx 57.52% <ø> (ø)
tomcat 60.41% <ø> (?)
torchserve 97.32% <ø> (ø)
traffic_server 96.13% <ø> (ø)
twistlock 80.47% <ø> (ø)
vault 95.53% <ø> (+0.57%) ⬆️
vertica 98.34% <ø> (ø)
voltdb 96.85% <ø> (ø)
vsphere 95.99% <ø> (+0.05%) ⬆️
weblogic 71.73% <ø> (ø)
windows_performance_counters 98.36% <ø> (ø)
windows_service 94.90% <ø> (+0.53%) ⬆️
zk 83.08% <ø> (+1.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

1 similar comment
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@iliakur iliakur enabled auto-merge (squash) March 21, 2024 16:40
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

Test Results

 1 036 files   1 036 suites   6h 38m 59s ⏱️
 6 921 tests  6 852 ✅    69 💤 0 ❌
30 518 runs  25 259 ✅ 5 259 💤 0 ❌

Results for commit fadf2c0.

Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

about the CI error:

  1. we install datadog_checks_dev 32.0.0 from source
  2. we install ddev from source, which depends on datadog_checks_dev 31, so the local version does not satisfy the requirement, so we get the wheel from PyPi, with the old version of this validation

so you'll need to bump the version in ddev right after dcd gets released

@iliakur iliakur merged commit 1a291c3 into master Mar 22, 2024
343 of 344 checks passed
@iliakur iliakur deleted the ik/release-dcd branch March 22, 2024 07:34
github-actions bot pushed a commit that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants