Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DBMON-3619] Add support for Postgres Wal metric #17144

Merged
merged 5 commits into from
Mar 12, 2024
Merged

[DBMON-3619] Add support for Postgres Wal metric #17144

merged 5 commits into from
Mar 12, 2024

Conversation

marlon-merida
Copy link
Contributor

@marlon-merida marlon-merida commented Mar 11, 2024 •
edited
Loading

What does this PR do?

Adds support for collecting wall metrics from postgres which become available after PG13.
The exact metrics are

  • wal_bytes
  • wal_fpi
  • wal_records

These metrics are useful when tuning INSERT/DELETE/UPDATE operations

Motivation

https://datadoghq.atlassian.net/browse/DBMON-3619

Additional Notes

Backend Change Pr:https://github.com/DataDog/dd-go/pull/126362

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@marlon-merida marlon-merida requested review from a team as code owners March 11, 2024 14:46
@marlon-merida marlon-merida marked this pull request as draft March 11, 2024 14:51
@marlon-merida marlon-merida marked this pull request as ready for review March 11, 2024 17:47
@marlon-merida marlon-merida requested review from trishankatdatadog and a team as code owners March 11, 2024 18:04
@marlon-merida marlon-merida requested a review from a team March 11, 2024 18:04
@marlon-merida marlon-merida requested review from a team as code owners March 11, 2024 18:04
@marlon-merida marlon-merida requested a review from mx-psi March 11, 2024 18:04
@marlon-merida marlon-merida force-pushed the marlon.meridagarcia/add_wal_metrics branch from 9ace4a9 to 6cdbcfc Compare March 11, 2024 18:17
@marlon-merida marlon-merida removed the request for review from trishankatdatadog March 11, 2024 18:18
@marlon-merida
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 11, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@github-actions GitHub Actions
Copy link

Test Results

   16 files     16 suites   21m 22s ⏱️
  274 tests   272 ✅   2 💤 0 ❌
2 200 runs  2 089 ✅ 111 💤 0 ❌

Results for commit b5b7a78.

@marlon-merida
Copy link
Contributor Author

marlon-merida commented Mar 11, 2024 •
edited
Loading

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Mar 11, 2024

❌ MergeQueue

PR is already in db with waiting status

If you need support, contact us on Slack #ci-interfaces with those details!

@marlon-merida
Copy link
Contributor Author

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Mar 11, 2024

⚠️ MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

@marlon-merida
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 11, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Mar 12, 2024

⚠️ MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

@FlorentClarret FlorentClarret merged commit fcc84d8 into master Mar 12, 2024
64 of 69 checks passed
@FlorentClarret FlorentClarret deleted the marlon.meridagarcia/add_wal_metrics branch March 12, 2024 07:32
marlon-merida added a commit that referenced this pull request Mar 12, 2024
@marlon-merida
[DBMON-3619] Add support for Postgres Wal metric (#17144)
6add5b8 
* add wal metrics

* remove wal_metrics from generic test

* add changelog

* format test to pass linter

* update changelog message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyle-Neale Kyle-Neale Kyle-Neale approved these changes

@jmeunier28 jmeunier28 jmeunier28 approved these changes

@lu-zhengda lu-zhengda lu-zhengda approved these changes

Assignees
No one assigned
Labels
integration/postgres mergequeue-status: removed team/agent-integrations team/database-monitoring-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marlon-merida @lu-zhengda @jmeunier28 @Kyle-Neale @FlorentClarret