Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sqlserver windows test env #17086

Closed
wants to merge 5 commits into from

Conversation

lu-zhengda
Copy link
Contributor

@lu-zhengda lu-zhengda commented Mar 6, 2024

What does this PR do?

This PR adds sqlserver-2017 & sqlserver-2022 to windows test env matrix.

isolation: hyperv is added to docker-compose to resolve issue The container operating system does not match the host operating system. This is a common issue when attempting to run Windows container images, as Windows containers require the host and container's base image to share the same kernel version. Hyper-V isolation provides a workaround for compatibility issues, allow us to use windows-2022 runner for all sqlserver windows tests.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (9b2de2a) to head (0387ecb).
Report is 16 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 88.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Mar 6, 2024

Test Results

   13 files     13 suites   57m 45s ⏱️
  278 tests   127 ✅  12 💤 28 ❌ 111 🔥
1 976 runs  1 677 ✅ 160 💤 28 ❌ 111 🔥

For more details on these failures and errors, see this check.

Results for commit 0387ecb.

♻️ This comment has been updated with latest results.

@lu-zhengda lu-zhengda changed the title add sqlserver 2022 to windows test env update sqlserver windows test env Mar 7, 2024
@lu-zhengda lu-zhengda closed this Mar 11, 2024
@lu-zhengda lu-zhengda deleted the zhengda.lu/sqlserver-win-tests branch March 11, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant