Adding further information regarding include_units
#17069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: - Working on a customer case, we discovered that the following prevented log collection: ``` include_units: - * ``` Supporting Documentation: - https://github.com/DataDog/datadog-agent/blob/7.50.x/pkg/logs/tailers/journald/tailer.go#L116-L126
Removed the "to collect"
cswatt
reviewed
Mar 6, 2024
Co-authored-by: cecilia saixue watt <[email protected]>
cswatt
approved these changes
Mar 6, 2024
marlon-merida
pushed a commit
that referenced
this pull request
Mar 11, 2024
* Update README.md Motivation: - Working on a customer case, we discovered that the following prevented log collection: ``` include_units: - * ``` Supporting Documentation: - https://github.com/DataDog/datadog-agent/blob/7.50.x/pkg/logs/tailers/journald/tailer.go#L116-L126 * Update README.md Removed the "to collect" * Update journald/README.md Co-authored-by: cecilia saixue watt <[email protected]> --------- Co-authored-by: Oliver Harrison <[email protected]> Co-authored-by: cecilia saixue watt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the fact that to collect all logs, we do not need to add a wildcard to the
include_unitssection.Motivation
Supporting Documentation:
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.