[Consul] Asset revamp #17064
Merged
[Consul] Asset revamp #17064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,1010 @@ | |||
| { | |||
| "title": "Consul Overview (new)", | |||
There was a problem hiding this comment.
Suggested change
| "title": "Consul Overview (new)", | |
| "title": "Consul Overview", |
I think
| "name": "Consul errors", | ||
| "type": "logs", | ||
| "page": "stream", | ||
| "query": "source:consul status:error", |
There was a problem hiding this comment.
in other integrations we also have an "overview" one that just "query": "source:consul",, do you think we should add it too?
steveny91
reviewed
Mar 6, 2024
Comment on lines
841
to
848
| "show_tick": true, | ||
| "tick_pos": "50%", | ||
| "tick_edge": "top", |
There was a problem hiding this comment.
Hmm I wonder what this does? 🤣
|
The |
Kyle-Neale
force-pushed
the
kyleneale/consul_asset_update
branch
from
f6fec5c to
f1a9b43
Compare
|
Created DOCS-7395 for docs review. |
maycmlee
added
the
editorial review
jhgilbert
approved these changes
Mar 11, 2024
| "name": "Consul errors", | ||
| "type": "logs", | ||
| "page": "stream", | ||
| "query": "source:consul ", |
There was a problem hiding this comment.
Suggested change
| "query": "source:consul ", | |
| "query": "source:consul", |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
* Consul asset revamp * fix monitor status widget and about sections * add aggregation by host to widgets * add consul logs overview * touch up 4ab7726
marlon-merida
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Consul asset revamp * fix monitor status widget and about sections * add aggregation by host to widgets * add consul logs overview * touch up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new OOTB dashboard for Consul. It also adds a new monitor and logs saved view
Motivation
https://datadoghq.atlassian.net/browse/AI-3763
https://datadoghq.atlassian.net/browse/AI-3781
https://datadoghq.atlassian.net/browse/AI-3759
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.