Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sy/argo rollouts #17006

Merged
merged 43 commits into from
Mar 21, 2024
Merged

Sy/argo rollouts #17006

merged 43 commits into from
Mar 21, 2024

Conversation

steveny91
Copy link
Contributor

@steveny91 steveny91 commented Feb 28, 2024 •
edited
Loading

What does this PR do?

Add new integration for Argo Rollouts. Things that should not be reviewed in this PR:

  • Log related items
  • Dashboards
  • Recommended Monitors

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

2 similar comments
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

1 similar comment
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 90.00%. Comparing base (cab48ee) to head (df5d074).
Report is 13 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
active_directory ?
activemq ?
activemq_xml ?
amazon_msk ?
ambari ?
apache ?
arangodb ?
argo_rollouts 90.00% <90.00%> (?)
argocd ?
aspdotnet ?
avi_vantage ?
azure_iot_edge ?
boundary ?
btrfs ?
cacti ?
calico ?
cassandra ?
cert_manager ?
cilium ?
cisco_aci ?
citrix_hypervisor ?
cloud_foundry_api ?
cloudera ?
cockroachdb ?
confluent_platform ?
consul ?
coredns ?
couch ?
couchbase ?
crio ?
datadog_checks_base ?
datadog_checks_dev ?
datadog_checks_downloader ?
datadog_cluster_agent ?
dcgm ?
ddev ?
directory ?
disk ?
dns_check ?
dotnetclr ?
druid ?
ecs_fargate ?
eks_fargate ?
envoy ?
etcd ?
exchange_server ?
external_dns ?
fluentd ?
fluxcd ?
foundationdb ?
gearmand ?
gitlab ?
gitlab_runner ?
glusterfs ?
go_expvar ?
gunicorn ?
harbor ?
hazelcast ?
hdfs_datanode ?
hdfs_namenode ?
hive ?
hivemq ?
http_check ?
ibm_ace ?
ibm_db2 ?
ibm_i ?
ibm_mq ?
ibm_was ?
ignite ?
impala ?
istio ?
jboss_wildfly ?
kafka ?
karpenter ?
kong ?
kube_apiserver_metrics ?
kube_controller_manager ?
kube_dns ?
kube_metrics_server ?
kube_proxy ?
kube_scheduler ?
kubelet ?
kubernetes_state ?
kyototycoon ?
lighttpd ?
linkerd ?
linux_proc_extras ?
mapr ?
mapreduce ?
marathon ?
mcache ?
mesos_master ?
mesos_slave ?
mysql ?
nagios ?
network ?
nfsstat ?
nginx ?
nginx_ingress_controller ?
nvidia_triton ?
openldap ?
openmetrics ?
openstack ?
openstack_controller ?
oracle ?
pdh_check ?
pgbouncer ?
php_fpm ?
postfix ?
postgres ?
powerdns_recursor ?
presto ?
process ?
prometheus ?
proxysql ?
pulsar ?
ray ?
redisdb ?
rethinkdb ?
riak ?
riakcs ?
scylla ?
silk ?
singlestore ?
snmp ?
snowflake ?
solr ?
spark ?
sqlserver ?
squid ?
ssh_check ?
statsd ?
strimzi ?
supervisord ?
system_core ?
system_swap ?
tcp_check ?
teamcity ?
tekton ?
temporal ?
teradata ?
tls ?
tokumx ?
torchserve ?
traffic_server ?
twemproxy ?
twistlock ?
varnish ?
vault ?
voltdb ?
vsphere ?
weaviate ?
weblogic ?
win32_event_log ?
windows_performance_counters ?
windows_service ?
wmi_check ?
yarn ?
zk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2024 •
edited
Loading

Test Results

2 files  2 suites   3s ⏱️
5 tests 5 ✅ 0 💤 0 ❌
6 runs  5 ✅ 1 💤 0 ❌

Results for commit df5d074.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

9 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@steveny91 steveny91 marked this pull request as ready for review March 6, 2024 21:34
@steveny91 steveny91 requested review from a team as code owners March 6, 2024 21:34
cswatt
cswatt reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some fairly minor edits for docs style

argo_rollouts/README.md Outdated Show resolved Hide resolved
argo_rollouts/README.md Outdated Show resolved Hide resolved
argo_rollouts/README.md Outdated Show resolved Hide resolved
argo_rollouts/README.md Outdated Show resolved Hide resolved
argo_rollouts/README.md Outdated Show resolved Hide resolved
steveny91 and others added 18 commits March 19, 2024 11:24
@steveny91 @cswatt
Update argo_rollouts/README.md
69663bb 
Co-authored-by: cecilia saixue watt <[email protected]>
@steveny91 @cswatt
Update argo_rollouts/README.md
7d0e611 
Co-authored-by: cecilia saixue watt <[email protected]>
@steveny91 @cswatt
Update argo_rollouts/README.md
ad30f83 
Co-authored-by: cecilia saixue watt <[email protected]>
@steveny91 @cswatt
Update argo_rollouts/README.md
05a4aaf 
Co-authored-by: cecilia saixue watt <[email protected]>
@steveny91 @FlorentClarret
Update argo_rollouts/README.md
55d2542 
Co-authored-by: Florent Clarret <[email protected]>
@steveny91 @FlorentClarret
Update argo_rollouts/datadog_checks/argo_rollouts/__about__.py
f1e1aa4 
Co-authored-by: Florent Clarret <[email protected]>
@steveny91 @FlorentClarret
Update argo_rollouts/manifest.json
ed5df44 
Co-authored-by: Florent Clarret <[email protected]>
@steveny91
fix remapped labels
17258ba
@steveny91
simplify check
1aff046
@steveny91
add service_checks test
7b777fa
@steveny91
add test for label rename
dbb2ce2
@steveny91 @FlorentClarret
Update argo_rollouts/tests/test_e2e.py
bf36e9a 
Co-authored-by: Florent Clarret <[email protected]>
@steveny91
simplify e2e
ae8f5d1
@steveny91
fix metadata
42ade2e
@steveny91
lint
c6c089d
@steveny91 @FlorentClarret
Update argo_rollouts/assets/configuration/spec.yaml
59a921f 
Co-authored-by: Florent Clarret <[email protected]>
@steveny91
Update check.py
8a73ac4
@steveny91
sort metrics
6ec8266
@steveny91 steveny91 merged commit 2b622f5 into master Mar 21, 2024
40 checks passed
@steveny91 steveny91 deleted the sy/argo-rollouts branch March 21, 2024 14:57
github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
@steveny91 @cswatt
Sy/argo rollouts (#17006)
070e746 
* argo-rollouts WIP

* add working env

* add simple tests

* nit

* add service check

* manifest tweaks

* validation syncs

* lint

* readme

* metadata

* validate

* fix metadata

* remove folder

* place holder dashboard

* place holder dashboard

* manifest metric to check

* manifest

* manifest

* labeler

* metadata descriptions

* Update argo_rollouts/README.md

Co-authored-by: cecilia saixue watt <[email protected]>

* Update argo_rollouts/README.md

Co-authored-by: cecilia saixue watt <[email protected]>

* Update argo_rollouts/README.md

Co-authored-by: cecilia saixue watt <[email protected]>

* Update argo_rollouts/README.md

Co-authored-by: cecilia saixue watt <[email protected]>

* Update argo_rollouts/README.md

Co-authored-by: cecilia saixue watt <[email protected]>

* Update argo_rollouts/README.md

Co-authored-by: Florent Clarret <[email protected]>

* Update argo_rollouts/datadog_checks/argo_rollouts/__about__.py

Co-authored-by: Florent Clarret <[email protected]>

* Update argo_rollouts/manifest.json

Co-authored-by: Florent Clarret <[email protected]>

* fix remapped labels

* simplify check

* add service_checks test

* add test for label rename

* Update argo_rollouts/tests/test_e2e.py

Co-authored-by: Florent Clarret <[email protected]>

* simplify e2e

* fix metadata

* lint

* Update argo_rollouts/assets/configuration/spec.yaml

Co-authored-by: Florent Clarret <[email protected]>

* Update check.py

* sort metrics

* fix mistakenly named metric

* fix mistakenly named metric

* cleanup

* add controller version as metadata

---------

Co-authored-by: cecilia saixue watt <[email protected]>
Co-authored-by: Florent Clarret <[email protected]> 2b622f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswatt cswatt cswatt left review comments

@FlorentClarret FlorentClarret FlorentClarret approved these changes

@iliakur iliakur iliakur approved these changes

@Kyle-Neale Kyle-Neale Kyle-Neale left review comments

Assignees
No one assigned
Labels
dev/testing dev/tooling documentation integration/argo_rollouts qa/skip-qa Automatically skip this PR for the next QA release team/agent-integrations team/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@steveny91 @iliakur @FlorentClarret @cswatt @Kyle-Neale