Skip to content

Commit

Permalink
Fix permissions in the "Check PR" action. (#19124)
Browse files Browse the repository at this point in the history
* Add missing permissions or pr-check.yml

* Add comments
  • Loading branch information
nubtron authored Nov 25, 2024
1 parent fb31dc3 commit f684057
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ jobs:
run:
uses: ./.github/workflows/pr-quick-check.yml
if: ${{ github.base_ref == 'master' }}
permissions: # These permissions need to match the ones in the included workflow, see pr-quick-check.yml for details
pull-requests: write
contents: read
with:
repo: core
secrets: inherit

4 changes: 2 additions & 2 deletions .github/workflows/pr-quick-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
runs-on: ubuntu-22.04

permissions:
pull-requests: write
contents: read
pull-requests: write # For the "Comment" step, read for the "Fetch script" and "Check changelog" steps
contents: read # For the "Fetch diff" and "Check changelog" steps

steps:
# Uncomment for testing purposes
Expand Down

0 comments on commit f684057

Please sign in to comment.