Skip to content

Commit

Permalink
Do not modify the agent build name if provided by the user when runni…
Browse files Browse the repository at this point in the history
…ng the e2e environments
  • Loading branch information
FlorentClarret committed Oct 19, 2023
1 parent 8a0d3f0 commit a84b35a
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 11 deletions.
4 changes: 4 additions & 0 deletions ddev/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

* Improve the upgrade-python script ([#16000](https://github.com/DataDog/integrations-core/pull/16000))

***Fixed***:

* Do not modify the agent build name if provided by the user when running the e2e environments ([#16053](https://github.com/DataDog/integrations-core/pull/16053))

## 5.2.1 / 2023-10-12

***Fixed***:
Expand Down
22 changes: 11 additions & 11 deletions ddev/src/ddev/e2e/agent/docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,17 +86,17 @@ def start(self, *, agent_build: str, local_packages: dict[Path, str], env_vars:
if not agent_build:
agent_build = 'datadog/agent-dev:master'

# Add a potentially missing `py` suffix for default non-RC builds
if (
'rc' not in agent_build
and 'py' not in agent_build
and agent_build != 'datadog/agent:6'
and agent_build != 'datadog/agent:7'
):
agent_build = f'{agent_build}-py{self.python_version[0]}'

if self.metadata.get('use_jmx') and not agent_build.endswith('-jmx'):
agent_build += '-jmx'
# Add a potentially missing `py` suffix for default non-RC builds
if (
'rc' not in agent_build
and 'py' not in agent_build
and agent_build != 'datadog/agent:6'
and agent_build != 'datadog/agent:7'
):
agent_build = f'{agent_build}-py{self.python_version[0]}'

if self.metadata.get('use_jmx') and not agent_build.endswith('-jmx'):
agent_build += '-jmx'

env_vars = env_vars.copy()

Expand Down

0 comments on commit a84b35a

Please sign in to comment.