spid as int

DataDog · Sep 19, 2024 · 6abe1f3 · 6abe1f3
1 parent c75fdc1
commit 6abe1f3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/sqlserver/datadog_checks/sqlserver/deadlocks.py b/sqlserver/datadog_checks/sqlserver/deadlocks.py
@@ -81,6 +81,11 @@ def _obfuscate_xml(self, root):
                     inputbuf.text = self.obfuscate_no_except_wrapper(inputbuf.text)
                     spid = process.get('spid')
                     if spid is not None:
+                        try:
+                            spid = int(spid)
+                        except ValueError:
+                            self._log.error("spid not an integer. Skipping query signature computation.")
+                            continue
                         if spid in query_signatures:
                             continue
                         query_signatures.append({"spid": spid, "signature": compute_sql_signature(inputbuf.text)})

diff --git a/sqlserver/tests/test_deadlocks.py b/sqlserver/tests/test_deadlocks.py
@@ -183,4 +183,6 @@ def test__create_deadlock_rows():
         row = rows[0]
         query_signatures = row["query_signatures"]
         assert len(query_signatures) == 2, "Should have two query signatures"
-        assert "spid" in query_signatures[0], "Should have spid in query signatures"
+        first_mapping = query_signatures[0]
+        assert "spid" in first_mapping, "Should have spid in query signatures"
+        assert isinstance(first_mapping["spid"], int), "spid should be an int"