Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Delete commas when escaping tag content #301

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mattwd7
Copy link
Contributor

@mattwd7 mattwd7 commented Dec 13, 2024

Addresses issue #300

#294 introduced a change wherein commas (,) are no longer deleted from tags unless that tag includes a pipe char (|). This causes tags containing commas to report differently than before the change, resulting in data misalignment.

This change will delete commas (again) if they are included in the tag string.

@mattwd7 mattwd7 requested a review from a team as a code owner December 13, 2024 20:13
Copy link
Contributor

@rayz rayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattwd7 ! I'll make a new release with this fix.

@rayz rayz merged commit 107c417 into DataDog:master Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants