Two-step log collection guideline #27184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboitreaud
force-pushed
the
adrien.boitreaud/mwaa-logs-collection
branch
from
803de2a to
10606b5
Compare
Preview links (active after the
|
warrierr
requested changes
Jan 17, 2025
Co-authored-by: Ryan Warrier <[email protected]>
warrierr
approved these changes
Jan 17, 2025
estherk15
approved these changes
Jan 17, 2025
| @@ -138,6 +142,8 @@ To get started, follow the instructions below. | |||
| [6]: https://docs.aws.amazon.com/mwaa/latest/userguide/mwaa-create-role.html | |||
| [7]: https://app.datadoghq.com/data-jobs/ | |||
| [8]: https://openlineage.io/docs/integrations/airflow/ | |||
| [9]: https://docs.aws.amazon.com/mwaa/latest/userguide/monitoring-airflow.html#monitoring-airflow-enable | |||
| [10]: https://docs.datadoghq.com/integrations/amazon_web_services/?tab=roledelegation#log-collection | |||
There was a problem hiding this comment.
Suggested change
| [10]: https://docs.datadoghq.com/integrations/amazon_web_services/?tab=roledelegation#log-collection | |
| [10]: /integrations/amazon_web_services/?tab=roledelegation#log-collection |
Comment on lines
+133
to
+135
| 4. Optionally, set up Log Collection for correlating task logs to DAG run executions in DJM by following the steps below: | ||
| 1. Configure Amazon MWAA to [send logs to CloudWatch][9]. | ||
| 2. [Send the logs to Datadog][10]. |
There was a problem hiding this comment.
I could go either way on this suggestion. If this step is confusing and needs to be broken down, leave as is!
Suggested change
| 4. Optionally, set up Log Collection for correlating task logs to DAG run executions in DJM by following the steps below: | |
| 1. Configure Amazon MWAA to [send logs to CloudWatch][9]. | |
| 2. [Send the logs to Datadog][10]. | |
| 4. Optionally, set up Log Collection for correlating task logs to DAG run executions in DJM by configuring Amazon MWAA to [send logs to CloudWatch][9], then [send the logs to Datadog][10]. |
| @@ -130,6 +130,10 @@ To get started, follow the instructions below. | |||
|
|
|||
| 3. Deploy your updated `requirements.txt` and [Amazon MWAA startup script][3] to your Amazon S3 folder configured for your Amazon MWAA Environment. | |||
|
|
|||
| 4. Optionally, set up Log Collection for correlating task logs to DAG run executions in DJM by following the steps below: | |||
There was a problem hiding this comment.
Suggested change
| 4. Optionally, set up Log Collection for correlating task logs to DAG run executions in DJM by following the steps below: | |
| 4. Optionally, set up Log Collection for correlating task logs to DAG run executions in DJM: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Add log collection step to DJM on MWAA setup guidelines. The two steps are taken from MWAA integration doc.
Merge instructions
Merge readiness: Not ready for merge, requires a
web-uichange for the trace correlation to work.Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes