Add Node.js DI documentation page #27150
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
watson
force-pushed
the
watson/DEBUG-2755/add-nodejs-docs
branch
5 times, most recently
from
cbf951a to
4cb79c7
Compare
| <div class="alert alert-info"><p><strong>Dynamic Instrumentation for Node.js is currently in limited preview!</strong></p><p>It is not available to all customers. To join the waiting list, <a href="https://forms.gle/TODO" target="_blank">fill out this form</a>.</p><p>Certain limitations apply to the limited preview. See <a href="#limitations">Limitations</a> for more information.</p></div> | ||
|
|
||
| {{< beta-callout-private url="https://forms.gle/TODO" >}} | ||
| <p><strong>Dynamic Instrumentation for Node.js is currently in limited preview!</strong></p> |
There was a problem hiding this comment.
Can we go with the copy from this version of the callout, but use the styling for the callout shown on this page? (That BigQuery preview callout was given as an example in a PM "how-to" doc for previewing products)
There was a problem hiding this comment.
I found a bunch of variations of that one. I've just pushed a commit with all of them so we can view them next to each other. We can edit the default text "Join the preview" to whatever we like and we can hide or show the button as we please.
There was a problem hiding this comment.
For reference, this is how the callout is currently rendered on the Google BigQuery page:
When I render the exact same callout in the preview for this page, the background has a different color:
I don't know if this is just a difference between staging and production or if this is because of where in the page hierarchy the callout is rendered. However, using the callout snippet, it's not possible to manually change the background color.
There was a problem hiding this comment.
I've adjusted to copy and layout slightly to work better with the general rendering of the callout - let me know what you think:
watson
force-pushed
the
watson/DEBUG-2755/add-nodejs-docs
branch
2 times, most recently
from
b7c81e0 to
5c79b36
Compare
watson
force-pushed
the
watson/DEBUG-2755/add-nodejs-docs
branch
from
5c79b36 to
5267746
Compare
| Dynamic Instrumentation for Node.js is currently in limited preview, which means it is not available to all customers. To join the waiting list, [fill out this form][6]. | ||
|
|
||
| The following limitations apply to the limited preview: |
There was a problem hiding this comment.
@sstonehill12 I'm considering just dropping one or both of these paragraphs. The first paragraph is already included in the callout at the top of the page and the second doesn't really add any value. Let me know what you think.
watson
force-pushed
the
watson/DEBUG-2755/add-nodejs-docs
branch
from
e7231f4 to
5267746
Compare
watson
force-pushed
the
watson/DEBUG-2755/add-nodejs-docs
branch
from
5267746 to
dc71835
Compare
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes